competition: fix

app/forms/competitions/save_team_form.rb

@@ -15,9 +15,13 @@ class Competitions::SaveTeamForm
 
   validate :check_teachers_enrollable
   def check_teachers_enrollable
-    if competition.teacher_enroll_forbidden? && teacher_ids.present?
+    if competition.teacher_enroll_forbidden? # 禁止老师报名
-      errors.add(:teacher_ids, :enroll_forbidden)
+      if teacher_ids.present?
-      return
+        errors.add(:teacher_ids, :enroll_forbidden)
+        return
+      end
+
+      return if creator.is_teacher? # 因为创建者有单独校验，所以这里跳过
     end
 
     self.teacher_ids = teacher_ids.map(&:to_i)
@@ -43,9 +47,13 @@ class Competitions::SaveTeamForm
 
   validate :check_members_enrollable
   def check_members_enrollable
-    if competition.member_enroll_forbidden? && member_ids.present?
+    if competition.member_enroll_forbidden? # 禁止学生报名
-      errors.add(:member_ids, :enroll_forbidden)
+      if member_ids.present?
-      return
+        errors.add(:member_ids, :enroll_forbidden)
+        return
+      end
+
+      return unless creator.is_teacher? # 因为创建者有单独校验，所以这里跳过
     end
 
     self.member_ids = member_ids.map(&:to_i)