Merge branch 'dev_aliyun' of https://bdgit.educoder.net/Hjqreturn/educoder into dev_Ysm

app/controllers/attachments_controller.rb

@@ -162,6 +162,7 @@ class AttachmentsController < ApplicationController
   def attachment_candown
     unless current_user.admin? || current_user.business?
       candown = true
+      unless params[:type] == 'history'
         if @file.container && current_user.logged?
           # 课堂资源、作业、毕设相关资源的权限判断
           if @file.container.is_a?(Course)
@@ -188,3 +189,4 @@ class AttachmentsController < ApplicationController
       end
     end
   end
+end

app/controllers/courses_controller.rb

@@ -1129,7 +1129,7 @@ class CoursesController < ApplicationController
 
   def validate_course_name
     tip_exception("课堂名称不能为空！") if params[:course][:name].blank?
-    if params[:subject_id].blank? || (@course && @course.subject.blank?)
+    if params[:subject_id].blank? && @course.blank? || (@course && @course.subject.blank?)
       tip_exception("课程名称不能为空！") if params[:course_list_name].blank?
       tip_exception("课堂名称应以课程名称开头命名") unless params[:course][:name].index(params[:course_list_name]) &&
         params[:course][:name].index(params[:course_list_name]) == 0

app/controllers/exercises_controller.rb

@@ -1566,15 +1566,22 @@ class ExercisesController < ApplicationController
 
   def check_user_id_start_answer #判断用户在开始答题时，是否有用户id传入,如果为老师，则id必需，否则为当前用户的id
     user_login = params[:login]
-    # exercise_current_user_id = params[:user_id]
     if user_login.blank? && @user_course_identity < Course::STUDENT  #id不存在，且当前为老师/管理员等
       normal_status(-1,"请输入学生登陆名！")
     else
-      @ex_answerer = User.find_by(login: user_login) #回答者
+      if @user_course_identity < Course::STUDENT || @exercise.score_open
+        @ex_answerer = user_login.blank? ? current_user : User.find_by(login: user_login)
+      else
+        @ex_answerer = current_user
+      end
+
       if @ex_answerer.blank?
         normal_status(404,"答题用户不存在")
+      elsif @user_course_identity > Course::STUDENT && !@exercise.is_public
+        normal_status(403,"非公开试卷")
       else
-        @exercise_current_user_id = @ex_answerer.id || current_user.id
+        # @exercise_current_user_id = @ex_answerer.id || current_user.id
+        @exercise_current_user_id = @ex_answerer.id
       end
     end
   end

app/helpers/application_helper.rb

@@ -258,7 +258,7 @@ module ApplicationHelper
   end
 
   def download_url attachment
-    attachment_path(attachment).gsub("/api","")
+    attachment_path(attachment)
   end
 
   # 耗时：天、小时、分、秒

app/models/homework_common.rb

@@ -36,7 +36,7 @@ class HomeworkCommon < ApplicationRecord
 
   validates :name, length: { maximum: 60 }
   validates :description, length: { maximum: 15000 }
-  validates :reference_answer, length: { maximum: 5000 }
+  validates :reference_answer, length: { maximum: 15000 }
 
   # after_update :update_activity
   before_destroy :update_homework_bank_quotes

app/views/attachment_histories/_attachment_history.json.jbuilder

@@ -8,3 +8,4 @@ json.downloads_count attachment.downloads_count
 json.created_on attachment.created_on
 json.url attachment_path(attachment, type: 'history').gsub("/api","")
 json.is_pdf attachment.is_history_pdf?
+json.attachment_id attachment.attachment_id

app/views/courses/settings.json.jbuilder

@@ -5,6 +5,7 @@ json.course_id @course.id
 json.school @course.school&.name
 json.class_period @course.class_period
 json.credit @course.credit
+json.start_date @course.start_date
 json.end_date @course.end_date
 json.is_public @course.is_public
 json.course_module_types @course.course_modules.where(hidden: 0).pluck(:module_type)

app/views/files/histories.json.jbuilder

@@ -1,3 +1,9 @@
 
-json.partial! 'attachments/attachment_small', attachment: @file
+# json.partial! 'attachments/attachment_small', attachment: @file
+json.id @file.id
+json.title @file.title
+json.filesize number_to_human_size(@file.filesize)
+json.url download_url(@file).gsub("/api","")
+json.created_on @file.created_on
+json.is_pdf @file.is_pdf?
 json.partial! "attachment_histories/list", attachment_histories: @attachment_histories

lib/tasks/excellent_course_exercise.rake

@@ -38,6 +38,8 @@ namespace :excellent_course_exercise do
         rand_num = index < pass_count - 1 ? 20 : rand(1..16)
       elsif exercise_question_ids.length == 17
         rand_num = index < pass_count - 1 ? rand(13..17) : rand(1..11)
+      elsif exercise_question_ids.length == 39
+        rand_num = index < pass_count - 1 ? rand(30..39) : rand(1..18)
       else
         rand_num = exercise_question_ids.length
       end

public/react/src/modules/courses/coursesDetail/CoursesLeftNav.js

@@ -721,15 +721,19 @@ class Coursesleftnav extends Component{
     let {url}=this.state;
     if (key === this.props.indexs) {
       this.props.unlocationNavfun(undefined)
+			this.props.history.replace(urls);
     } else {
       this.props.unlocationNavfun(key)
-    }
-    if(urls!=url){
 			this.props.history.replace(urls);
     }
-    if(this.props.indexs===undefined){
+    if(urls!=url){
       this.props.history.replace(urls);
     }
+    // if(this.props.indexs===undefined){
+		//
+		// }else{
+		//
+		// }
   }
 
   maincontent=(item,key)=>{

public/react/src/modules/paths/PathDetail/DetailCards.js

@@ -226,10 +226,11 @@ class DetailCards extends Component{
 					startshixunCombattype:true,
 				})
 			} else {
-				window.location.href = "/tasks/" + response.data.game_identifier;
+				// window.location.href = "/tasks/" + response.data.game_identifier;
 				// window.location.href = path
 				// let path="/tasks/"+response.data.game_identifier;
 				// this.props.history.push(path);
+				window.open("/tasks/" + response.data.game_identifier);
 			}
 		}).catch((error) => {