新建实训问题

app/controllers/shixuns_controller.rb

@@ -364,7 +364,12 @@ class ShixunsController < ApplicationController
 	end
 
 	def create
+		begin
 		@shixun = CreateShixunService.call(current_user, shixun_params, params)
+		rescue => e
+			logger_error("shixun_create_error: #{e.message}")
+			tip_exception("创建实训失败！")
+		end
 	end
 
 	def update

app/services/shixuns/create_shixun_service.rb

@@ -13,7 +13,6 @@ class CreateShixunService < ApplicationService
     shixun.identifier= identifier
     main_mirror = MirrorRepository.find params[:main_type]
     sub_mirrors = MirrorRepository.where(id: params[:sub_type])
-    begin
     ActiveRecord::Base.transaction do
       shixun.save!
       # 获取脚本内容
@@ -43,10 +42,6 @@ class CreateShixunService < ApplicationService
       end
       return shixun
     end
-    rescue => e
-      Rails.logger.error(e.message)
-      render_error("实训创建失败:#{e.message}")
-    end
   end
 
   private
@@ -102,7 +97,7 @@ class CreateShixunService < ApplicationService
 
   # 版本库目录空间
   def repo_namespace(user, shixun_identifier)
-    "#{user.login}/#{shixun_identifier}.git"
+    "#{user}/#{shixun_identifier}.git"
   end
 
 end