Fix some review issues.

master
Yuhao Zhou 6 years ago
parent 067d4d1193
commit d6ce309247

@ -1,8 +0,0 @@
//! Workaround for missing compiler-builtin symbols
//!
//! [atomic](http://llvm.org/docs/Atomics.html#libcalls-atomic)
#[no_mangle]
pub extern fn abort() {
panic!("abort");
}

@ -50,8 +50,8 @@ pub struct TrapFrame {
pub sp: usize, pub sp: usize,
pub fp: usize, pub fp: usize,
pub ra: usize, pub ra: usize,
/// Reserve space for hartid /// Reserved
pub _hartid: usize, pub reserved: usize,
} }
impl TrapFrame { impl TrapFrame {

@ -1,4 +1,5 @@
use mips::registers::cp0; use mips::registers::cp0;
use mips::instructions;
use crate::consts::MAX_CPU_NUM; use crate::consts::MAX_CPU_NUM;
use core::ptr::{read_volatile, write_volatile}; use core::ptr::{read_volatile, write_volatile};
@ -21,7 +22,7 @@ pub unsafe fn start_others(hart_mask: usize) {
} }
pub fn halt() { pub fn halt() {
/* nothing to do */ unsafe { instructions::wait(); }
} }
pub unsafe fn exit_in_qemu(error_code: u8) -> ! { pub unsafe fn exit_in_qemu(error_code: u8) -> ! {

Loading…
Cancel
Save