b4099518f8
Fix tooltip pager feature
...
Updates to tooltip.js for msg spec changes.
12 years ago
997a9735f0
Merge pull request #5320 from jdfreder/focusbug_tt
...
Fix for Tooltip & completer click focus bug.
12 years ago
c5054883e9
small fixes for #5320
12 years ago
aed8b7ba3c
Remove commented out lines (for tab evt)
12 years ago
cbab393e44
Shrink cleanup lines
12 years ago
ee7f5b8235
Move width auto into less
12 years ago
bca3fdc4b0
Remove commented line
12 years ago
bf65d5837f
Finish implementing codemirror events
12 years ago
a2071db309
More progress...
12 years ago
b2ec594c76
Getting a lot closer...
12 years ago
23494f4ddd
Set tabindex -1, use codemirror's events
12 years ago
dc6355ffb7
Prevent tab key from bubbling when the completer is open
12 years ago
0493027d7e
Merge pull request #5403 from minrk/alt-shortcut-bad
...
remove alt-- shortcut
12 years ago
840364ff71
use box-flex to layout quickhelp
12 years ago
19c64f4b59
remove alt-- shortcut
...
replace with ctrl-shift--
alt is not safe for defaults
12 years ago
9f1b26d860
Merge pull request #5331 from minrk/raw-input-css
...
fix raw_input CSS
12 years ago
0ae0216b12
Merge pull request #5049 from ivanov/quickhelp-update
...
update quickhelp on adding and removing shortcuts
12 years ago
35c861f583
fix MacOS specific shortcuts, thanks @minrk
12 years ago
c28096f0c5
prevent saving of partially loaded notebooks
...
closes #5363
12 years ago
54d9eb4358
really fix the '-' key shortcuts now
12 years ago
77bf4a72dd
better handling of minus
12 years ago
21ebaf2e32
handle keyboard shortcuts ending with '-'
12 years ago
4cf1717980
use - for shortcut separators
12 years ago
d88b2ccc4a
Merge pull request #5310 from ivanov/fix-5238
...
remove raw cell placeholder on focus, closes #5238
12 years ago
5c5139b65d
Merge pull request #5332 from ivanov/semantic-icons
...
semantic names for indicator icons
12 years ago
2e4036fd4f
raw cell placeholder text as one line
12 years ago
37852baa6d
render on focus out, always pad raw cells
12 years ago
955d239d07
rename css class names to be consistent with current style
12 years ago
a0a17fa04a
capitalize keyboard shortcuts in the tour
12 years ago
00603a11f6
remove stale modal dialog from the DOM
12 years ago
5f086fded2
Merge pull request #5372 from minrk/no-close-strings
...
Don't autoclose strings, because CodeMirror's behavior makes it confusing and awkward to type triple-quoted strings (and these are very common in Python).
An issue about this was filed in CodeMirror itself: https://github.com/marijnh/CodeMirror/issues/2385
12 years ago
3c1fe84f52
Don't autoclose strings
...
CodeMirror doesn't do the right thing with triple-quoted strings,
so don't let it try.
12 years ago
b9ef37ac26
semicolon fixes buttress half of my js commits
12 years ago
e64c2cb5d8
Merge pull request #5296 from ivanov/more-shortcuts
...
unify keyboard shortcut and codemirror interaction
12 years ago
0c366861c5
brief key event desription
12 years ago
6d6e0fb007
fix up and down arrows in the top and bottom cells
12 years ago
09866e0ee1
go to the beginning of the line when entering cell
12 years ago
96848748de
restore master behavior
...
up arrow at the top line first goes to char 0, and only goes to the cell
above if already on char 0. Same with down arrow on the bottom line:
transition cursor to the end of the line, and only go down a cell if
already at the end of the last line.
this makes for an unhappy experience in code-mirror's vim mode for j
and k keys, but we'll fix that in the next commit
12 years ago
8f17444c27
go to appropriate line when coming from another cell
...
Sets the cursor on the last line of the cell when moved up from the top
of the cell below, and sets the cursors to the first line when moving
down from the bottom of a last line.
Here, we retain the character that the cursor was on, so that users
wishing to have up-down functionality like one document can still use
this shortcut handler and simple adjust the at_top and at_bottom methods
12 years ago
d37ffe91b7
Fix status ind. icon bug
12 years ago
065a6eaa34
fix ambiguous raw_input classes
12 years ago
61b47695e4
renamed 'use_shortcut' method to 'handles'
12 years ago
d8287466d0
another doc fix
12 years ago
f68dcc3e57
it's only half true that I'm anal about semicolons
12 years ago
67fd905421
minor fixes to docs to address PR feedback
12 years ago
469c70fd10
more semicolons
12 years ago
443083c1fd
Added some comments
12 years ago
1dc113a9cb
closes #5336
12 years ago
4142911ac7
better fix for starting with Command Mode icon
12 years ago
12139b4d6e
ensure ipython-command-mode icon displayed on load
12 years ago
f0ae836f5f
semantic names for kernel status indicator
12 years ago
f5a02a02dd
semantic names for indicator icons
...
For all of the discussion that we had about what kind of icons should
and should not be used to indicate what mode the notebook is in, we
never went through to make it possible to override it.
With this change, it is now possible to override what icons are
displayed for Command and Edit Modes.
For example, @minrk liked the fighter-jet icon for Command Mode, so he
can put this in his custom.css
.ipython-command-mode:before {
content: "\f0fb";
}
12 years ago
4dd009f198
DRY: style in one place, removed code duplication
12 years ago
7762cb0ab3
Fixed a small bug/typo
12 years ago
e61b6aef47
Add logic to close tt when cell is unselected
12 years ago
b08665563d
fix capitalization of mode-switching keys
12 years ago
a24595d16b
call append_text from append_map
12 years ago
01c9be84d0
prettify combo keyboard shortcuts
12 years ago
1c213bc615
first pass at capitalizing keyboard shortcuts
12 years ago
95492b0f42
Add illusion that cell is in edit mode when complete is up,
...
even though it is not in focus so it is not in edit mode.
12 years ago
65732920eb
Remove all should cancel blur logic.
12 years ago
989ae4e1b3
Workaround for Tooltip & completer click focus bug.
12 years ago
8bf4ffa2ca
rebuild.QuickHelp event sets the dirty bit
...
QuickHelp is rebuilt on show if the dirty bit was set.
12 years ago
cd38181438
remove raw cell placeholder on focus, closes #5238
12 years ago
4d1f9b21c4
append functions are not prototype methods
12 years ago
54409a196d
dem semicolons
12 years ago
19c7189b15
no need to special-case Escape anymore
12 years ago
6a2c4121f9
up and down keys no longer need special casing
12 years ago
2c9ff376a2
added new use_shortcut method to shortcuts
...
this way, you can ask if a particular event will be handled by the
shortcuts system. This takes away the need to special-case many
different possible keys which should be ignored by codemirror by
ignoring them en masse.
12 years ago
b9e448b160
DRY: refactor common keyboard handling to Cell
...
Our edit mode keyboard shortcuts don't distinguish between being in a
code cell or in a text cell, so it makes sense to handle both in one
place. This is a first step in that direction.
12 years ago
15f4345ba3
typo, use keycodes object instead of magic numbers
12 years ago
bf3ecdb35f
DRY: factor out common handle_keyevent method
...
This method was identical in both CodeCell and TextCell
12 years ago
71d4c427c9
refactor to improve cell switching in edit mode
...
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.
TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell
prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.
The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
12 years ago
8889a7581c
start better keyboard handling
12 years ago
30c500bfa9
Merge pull request #5292 from jdfreder/shift-enter-scroll
...
focus next cell on shift+enter
12 years ago
da334e782e
focus next cell on shift+enter
12 years ago
0a37d7bfc5
Merge pull request #5232 from jdfreder/nbc_incono
...
Make nbconvert html full output like notebook's html.
12 years ago
05e6fbade4
Merge pull request #5288 from minrk/start-idle
...
Correct initial state of kernel status indicator
12 years ago
80af3b4cfb
Merge pull request #4802 from ivanov/ui-docs
...
Tour of the notebook UI (was UI elements inline with highlighting)
12 years ago
e901c9be33
Correct initial state of kernel status indicator
...
- start as busy, since we don't know
- send a kernel_info request once connections are established
- set idle on reply to the to the kernel_info request
12 years ago
9c5bca99e2
addClass instead of adding extra_class arg everywhere
12 years ago
6169acfc6d
Fixed rebase issues
12 years ago
8b3c356c8d
Add extra_class arg to the rest of the append methods,
...
use new extra_arg to add output_pyout class
12 years ago
b92ede2800
Added output_pyerr to python error output
12 years ago
1407b4347e
Merge pull request #5268 from ellisonbg/cmd-mode
...
Refactoring Notebook.command_mode
12 years ago
610e66615e
added a note to what's new
12 years ago
7974e32150
oops, <tt> went the way of the dodo, using <code>
12 years ago
06e5858ee2
lower case names for keys
12 years ago
7d87978a66
fix a typo introduced by a rebased PR
...
caused heading cells to appear in both rendered and unrendered state
12 years ago
fdca0762a4
tidy up capitalization
12 years ago
e10afab397
rewording according to feedback in #4802
12 years ago
490e4d1e42
horizontally center menubar popup
12 years ago
4371ebf625
fix vertical position of command mode tooltip
12 years ago
54e1558c16
make trust notebook dialog a single paragraph
12 years ago
8cd744db85
mention that Trust triggers reload
12 years ago
4e0a2ee476
Make sure we are in command mode before we select a new cell.
12 years ago
d5b0026cf1
trust via mark cells and save, rather than trust API request
12 years ago
6792d38215
log excluded untrusted output
12 years ago
aaefc5f296
remove warning for stripped output
12 years ago
b5c8a51331
disable trust notebook menu item on trusted notebooks
12 years ago
1ae689f30c
Add Trust Notebook to File menu
12 years ago
5f7f1c51ec
remove unused security warning
12 years ago
6384502e47
sanitize untrusted HTML output
...
rather than checking is_safe
12 years ago
3d0957c7bc
trust latex
...
If mathjax is insecure, we have big problems.
And we already trust mathjax in markdown cells,
so this is consistent.
12 years ago
890c0be1dd
always sanitize markdown
...
don't check if it's safe or not
12 years ago
3b262912a1
Display safe HTML+SVG even if untrusted, but don't set trusted=1.
12 years ago
31c9e08fa8
Don't render insecure Markdown and show warning.
12 years ago
fa3f998295
Adding security.js with 1st attempt at is_safe.
12 years ago
6f4263dc74
Removing conditionals that are not needed.
12 years ago
e374ca5ebb
Refactoring Notebook.command_mode.
12 years ago
92967c0baf
Addressing things in completer.js.
12 years ago
af7dd15181
Removing old keyboard handling from IPython.utils.
12 years ago
ff1492f8c9
Creating new base/js/keyboard.js
12 years ago
ede116bee7
Get cell after first conditional
12 years ago
479bc6b37a
Check down too.
12 years ago
bebe51c158
Don't allow edit mode up arrow to continue past index == 0
12 years ago
1ce7d5ec80
tour: put the right arrow on the right side
12 years ago
8c5b32c987
Merge pull request #5223 from minrk/tiny-images
...
use on-load event to trigger resizable images
12 years ago
6d0d34d7ed
entering edit mode now requires focus_cell
12 years ago
bdbf2fe9d5
more robust forward and back tour transitions
12 years ago
ccf6128962
addressing Fernando's feedback
12 years ago
95bd36be10
don't automatically advance the tour
12 years ago
9d1595aebb
more refinement of the tour contents
12 years ago
405017875e
tidy up and add to the tour
...
@takluyver found some typos which I fixed now
12 years ago
d11d9b4830
tidying up the tour explanation of modes
12 years ago
3a43d776c2
End tour via 'x' in upper right corner of window
12 years ago
1ee52fcbbc
pause/play buttons for starting/stopping the tour
12 years ago
5725bf80f5
use minified tour
12 years ago
600facc92d
allow tour restarting
12 years ago
abe4732aa0
fix typo in tour.js
12 years ago
5fead3cdd7
starting the tour from the menu works now
...
JavaScript makes me fond of this phrase:
When there's nothing left to burn, you have to set yourself on fire.
12 years ago
d7b569390f
more work on the tour
12 years ago
3cf601b58e
initial bootstrap tour
...
One way to get it to play currently is with a cell like this:
%%javascript
$.getScript('/static/notebook/js/tour.js')
provided that you have Bootstrap Tour installed in the components
12 years ago
15fac2c1d6
make input_area css generic to cells
...
removes otherwise-identical text_cell_input class in text cells
12 years ago
983271a36f
use on-load event to trigger resizable images
...
instead of timeout, which could get incorrect size information.
closes #5219
12 years ago
88460cd212
Merge pull request #5175 from jdfreder/html-take2
...
Audit .html() calls take #2
12 years ago
39d39d0ea6
s/trigger_edit_mode/edit_mode
12 years ago
c41fe67da2
Re-added removed refresh
12 years ago
3bcee30e8c
Added comments to kbm and shrunk focus_cell lines
12 years ago
69e760841a
Move should cancel blur into codecell
12 years ago
4fdc99e111
Remove notebook load log succes
12 years ago
a6f883d7f2
Couple of whiteboard logic implementation misses
12 years ago
9451589e38
implemented whiteboard logic
12 years ago
0884716a7d
Re-added widget textbox blur fix FF
12 years ago
bfc51c2a29
Final touches?
12 years ago
c5fb037e41
Reorg index and focus_editor params on edit_mode func
12 years ago
048ca30b0c
Remove fixes that are implemented correct in new CM
12 years ago
e847a31348
Always refresh the CM editor upon TextCell unrender.
12 years ago
b976804051
Moved edit_mode canceling logic back into cell.
12 years ago
ff37fb7a36
Standardized comments and removed last logs
12 years ago
64ae25508d
Removed change that is no longer needed
12 years ago
70086d352f
s/unfocus/blur
12 years ago
c7860d8bc8
Post in person review
...
Removed logic for reverse ordered events
Removed almost all of the log statements
Removed list for should unfocus callbacks
Removed all the logic in focus_editor
Only call focus_editor if the keyboard was used to enter edit mode
12 years ago
3595c099c2
Fixed rebase problems
12 years ago
10d79a9102
Added cell unfocus event canceller API
12 years ago
a6aaa8a886
Use is_focused for element kbman removal event
12 years ago
6f7c502157
Fixed lots of bugs
...
Half overhaul of notebook focus events...
12 years ago
206d35a89e
DEBUG
...
Added lots of log calls and a couple small 'fixes' (attempts)
12 years ago
7913305312
jshint
12 years ago
bdde544d47
don't forget base_url when updating address bar in rename
12 years ago
6c1ef48f1a
Merge pull request #5173 from jdfreder/movewidgets
...
Moved widget files into static/widgets/*
12 years ago
0117b587ab
Merge pull request #4985 from damianavila/closebrackets
...
Enable autoCloseBrackets in CodeMirror by default.
12 years ago
371afec677
Merge pull request #5112 from minrk/completion-band-aid
...
Band-aid for completion in the notebook: not the ideal solution, but will have to do the job for now so that typing while completing works.
closes #4860
12 years ago
edb8d68331
Merge pull request #5132 from minrk/oops-pdf-transform
...
remove application/pdf->pdf transform in javascript
12 years ago
28423647a2
Updated require references to point to new files
12 years ago
e0ba52c802
Moved widget files into static/widgets/*
...
Since they do not depend on anything ntoebook related
12 years ago
612acd2e08
Merge pull request #5170 from jdfreder/widget-throttle-trait
...
Added msg_throttle sync=True widget traitlet
12 years ago
eda4569099
Merge pull request #5037 from jdfreder/ff-widget-align
...
FF Fix: alignment and scale of text widget
12 years ago
ef3f61f906
Use set_rendered to set the error msg of the cell.
12 years ago
946212d5fa
Treat set_rendered as unsafe.
12 years ago
407fc0a017
s/with with/with
12 years ago
6a224d131b
Move todos into set_rendered
12 years ago
db4960769b
Merge pull request #5100 from minrk/base_kernel_url
...
remove base_kernel_url
12 years ago
ad03225cf6
Audit .html() calls take #2
12 years ago
0e56051a01
Added parentheses to emphasize order of op.
12 years ago
0eebd9e05b
Added msg_throttle sync=True widget traitlet
12 years ago
3b8beec541
Added a class for RadioButtons container
...
with appropriate top padding...
12 years ago
efc01b8854
remove append_json reference
...
we never had such a method
12 years ago
a7fb5e1e55
Merge pull request #5114 from minrk/empty-button
...
use non-breaking space for button with no description
12 years ago
ea8896399b
remove application/pdf->pdf transform in javascript
...
We have the old transforms because they were added before we realized it was a bad idea. We should not add new ones.
12 years ago
59d3a8ff5f
handle empty string in ToggleButtonsWidget
12 years ago
0eff2bb651
handle space-only strings, not just zero-length
12 years ago
c50096334c
use non-breaking space for button with no description
...
to preserve button's size
reverses some inappropriate replacements of .html with .text.
closes #5113
12 years ago
fd346d1790
fix remove event in KeyboardManager.register_events
...
only call enable on remove when focused.
fixes a bug where command mode could be entered inappropriately
when non-focused elements are removed from the page
(see first `@interact` example).
12 years ago
a1e263785c
band-aid for completion
...
Unlike @Carreau's attempt at using proper CodeMirror completion,
this is just a band-aid to get the existing completion back to working for 2.0.
This adds a keypress handler on the completer,
which then calls insert with the charCode of the key press event,
replacing the final `elif` branch of the keydown handler.
This cannot be done with keydown,
since keydown doesn't know what character is incoming,
only the hardware key that is struck.
12 years ago
a184724bdb
remove base_kernel_url
12 years ago
1c564131c5
Fixed, set on recieve update triggering echos.
12 years ago
7b2787e508
Fixed typo
12 years ago
f4f2c92285
Keep a running diff instead of forcing a full state update
12 years ago
770d2bd3a0
Only send diff message if diff isn't corrupt.
...
Diff will corrupt if more then one model.set(...) call is made
before model.save (or view.touch() in our case).
12 years ago
5667947f9d
Revert "Let backbone get changed attrs"
...
This reverts commit 4dd4990ff146508894353e390601c659d2638ed3.
12 years ago
36b576b0bd
Let backbone get changed attrs
12 years ago
cd72883fc7
Revert "Fix incorrect usage of attrs"
...
This reverts commit 04aa0885bb143fd0409fe133ca572004ffa6dc0e.
12 years ago
0d80363240
Fix incorrect usage of attrs
12 years ago
a93040e810
s/get_data/get_body_data/
12 years ago
e7db8cfd4e
fix notebook_path in menu bar
12 years ago
e1e0b19a6a
s/base_project_url/base_url/
...
deprecate NotebookApp.base_project_url
12 years ago
24703985e9
only add .ipynb if extension is not included
...
prevents .ipynb.ipynb double extension
12 years ago
61b06a39e2
holy crap, semicolons
12 years ago
13fc9022d9
various unicode fixes
...
- remove notebookPath, notebookName, and baseProjectUrl methods everywhere
- use base_project_url *attributes* instead
- we should never use escaped URLs except when making an actual request
Should fix issues with double-escaping
12 years ago
Jonathan Frederic
Paul Ivanov
Paul Ivanov
Jonathan Frederic
Min RK
Brian E. Granger
Fernando Perez
Thomas Kluyver