Most user don't care how to get the token each time (if they see the
message). They want to avoid using a token.
Make it clearer that Password should be configured.
Be more tricky, say that password not configured **yet**, to make the
user think they __have to__.
The text is not technically correct as as far as I remember you can have
PW and Token at the same time. But I'm going to say that in 99% of case
where users read that, the password is unset.
Closes gh-2245, I hope, but I don't know if there's a better way to fix
it.
I think we need to calculate the location relative to the 'offset
parent' of the tooltip. Adding one extra parent level from CodeMirror
seems to work at the moment.
- replace regexes they were not matching at the end of files.
- hide edit/view for multiple, they where not working
From the Pr comments that should closely match the following
Observations:
- "View" is handled by the browser so in most case it's something
"safe". I think that (A) all items we don't know what to do with
should have the _possibility_ to be viewed. (example `config.yaml`,
`cat.gifv`).
- "Edit" make sens only on text files only. In general (B) "edit"
should not be the default action for most files.
- Though (C) "Edit" should be triggerable by advanced users (unless
we know we should not). Example `foo.zorblax`, `conf.toml`
- (D) "Edit" does not make sens for some filetypes, thus should not be
available (`'png`, `.jpeg`)
Question (E):
- If the default action is X {in edit/view} should the X button be shown ?
Proposition:
- if ipynb:
- default link edit
- no button in toolbar.
- If known type, editable (txt, json, yaml, py, rb):
- default link open edit,
- button in toolbar show view
- if known type not editable: (, png, gif, zip)
- default link open view
- no button in toolbar
- if unknown type ('.zorblax, toml, cson, ')
- default link open "view"
- button in the toolbar show "Edit".
In the future I would like to show the Edit button for notebooks
but have it open them in the text editor. Right now, there isn't
any way for a user to do this. Thus hiding Edit on notebooks for
now.
This removes the showing of the Edit button when:
* We know we can't edit the file (pdf, doc, xls, jpeg, png, etc.)
* Or a notebook - looking at this again though...
Ioannis Papadopoulos
Min RK
Michael Pacer
Grant Nestor
Kyle Kelley
Matthias Bussonnier
michaelpacer
Thomas Kluyver
Kaushik Chaubal
Lorenzo Gasparini
Thomas Kluyver
Louise Davies
Peter Parente
Brian E. Granger
Joris Van den Bossche
Carol Willing