71d4c427c9
refactor to improve cell switching in edit mode
...
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.
TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell
prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.
The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
12 years ago
8889a7581c
start better keyboard handling
12 years ago
30c500bfa9
Merge pull request #5292 from jdfreder/shift-enter-scroll
...
focus next cell on shift+enter
12 years ago
da334e782e
focus next cell on shift+enter
12 years ago
0a37d7bfc5
Merge pull request #5232 from jdfreder/nbc_incono
...
Make nbconvert html full output like notebook's html.
12 years ago
05e6fbade4
Merge pull request #5288 from minrk/start-idle
...
Correct initial state of kernel status indicator
12 years ago
80af3b4cfb
Merge pull request #4802 from ivanov/ui-docs
...
Tour of the notebook UI (was UI elements inline with highlighting)
12 years ago
e901c9be33
Correct initial state of kernel status indicator
...
- start as busy, since we don't know
- send a kernel_info request once connections are established
- set idle on reply to the to the kernel_info request
12 years ago
f62ce75a62
Lots of CSS tweaks to get nbconvert output looking right.
12 years ago
9c5bca99e2
addClass instead of adding extra_class arg everywhere
12 years ago
6169acfc6d
Fixed rebase issues
12 years ago
8b3c356c8d
Add extra_class arg to the rest of the append methods,
...
use new extra_arg to add output_pyout class
12 years ago
b92ede2800
Added output_pyerr to python error output
12 years ago
1407b4347e
Merge pull request #5268 from ellisonbg/cmd-mode
...
Refactoring Notebook.command_mode
12 years ago
610e66615e
added a note to what's new
12 years ago
7974e32150
oops, <tt> went the way of the dodo, using <code>
12 years ago
06e5858ee2
lower case names for keys
12 years ago
7d87978a66
fix a typo introduced by a rebased PR
...
caused heading cells to appear in both rendered and unrendered state
12 years ago
72864cc83c
append Firefox overflow-x fix
12 years ago
fdca0762a4
tidy up capitalization
12 years ago
e10afab397
rewording according to feedback in #4802
12 years ago
490e4d1e42
horizontally center menubar popup
12 years ago
4371ebf625
fix vertical position of command mode tooltip
12 years ago
54e1558c16
make trust notebook dialog a single paragraph
12 years ago
8cd744db85
mention that Trust triggers reload
12 years ago
4e0a2ee476
Make sure we are in command mode before we select a new cell.
12 years ago
d5b0026cf1
trust via mark cells and save, rather than trust API request
12 years ago
6792d38215
log excluded untrusted output
12 years ago
aaefc5f296
remove warning for stripped output
12 years ago
b5c8a51331
disable trust notebook menu item on trusted notebooks
12 years ago
1ae689f30c
Add Trust Notebook to File menu
12 years ago
5f7f1c51ec
remove unused security warning
12 years ago
6384502e47
sanitize untrusted HTML output
...
rather than checking is_safe
12 years ago
3d0957c7bc
trust latex
...
If mathjax is insecure, we have big problems.
And we already trust mathjax in markdown cells,
so this is consistent.
12 years ago
890c0be1dd
always sanitize markdown
...
don't check if it's safe or not
12 years ago
3b262912a1
Display safe HTML+SVG even if untrusted, but don't set trusted=1.
12 years ago
31c9e08fa8
Don't render insecure Markdown and show warning.
12 years ago
fa3f998295
Adding security.js with 1st attempt at is_safe.
12 years ago
6f4263dc74
Removing conditionals that are not needed.
12 years ago
e374ca5ebb
Refactoring Notebook.command_mode.
12 years ago
92967c0baf
Addressing things in completer.js.
12 years ago
af7dd15181
Removing old keyboard handling from IPython.utils.
12 years ago
ff1492f8c9
Creating new base/js/keyboard.js
12 years ago
ede116bee7
Get cell after first conditional
12 years ago
479bc6b37a
Check down too.
12 years ago
bebe51c158
Don't allow edit mode up arrow to continue past index == 0
12 years ago
1ce7d5ec80
tour: put the right arrow on the right side
12 years ago
8c5b32c987
Merge pull request #5223 from minrk/tiny-images
...
use on-load event to trigger resizable images
12 years ago
6d0d34d7ed
entering edit mode now requires focus_cell
12 years ago
bdbf2fe9d5
more robust forward and back tour transitions
12 years ago
ccf6128962
addressing Fernando's feedback
12 years ago
95bd36be10
don't automatically advance the tour
12 years ago
9d1595aebb
more refinement of the tour contents
12 years ago
405017875e
tidy up and add to the tour
...
@takluyver found some typos which I fixed now
12 years ago
d11d9b4830
tidying up the tour explanation of modes
12 years ago
3a43d776c2
End tour via 'x' in upper right corner of window
12 years ago
1ee52fcbbc
pause/play buttons for starting/stopping the tour
12 years ago
5725bf80f5
use minified tour
12 years ago
600facc92d
allow tour restarting
12 years ago
abe4732aa0
fix typo in tour.js
12 years ago
5fead3cdd7
starting the tour from the menu works now
...
JavaScript makes me fond of this phrase:
When there's nothing left to burn, you have to set yourself on fire.
12 years ago
d7b569390f
more work on the tour
12 years ago
3cf601b58e
initial bootstrap tour
...
One way to get it to play currently is with a cell like this:
%%javascript
$.getScript('/static/notebook/js/tour.js')
provided that you have Bootstrap Tour installed in the components
12 years ago
15fac2c1d6
make input_area css generic to cells
...
removes otherwise-identical text_cell_input class in text cells
12 years ago
983271a36f
use on-load event to trigger resizable images
...
instead of timeout, which could get incorrect size information.
closes #5219
12 years ago
88460cd212
Merge pull request #5175 from jdfreder/html-take2
...
Audit .html() calls take #2
12 years ago
39d39d0ea6
s/trigger_edit_mode/edit_mode
12 years ago
c41fe67da2
Re-added removed refresh
12 years ago
3bcee30e8c
Added comments to kbm and shrunk focus_cell lines
12 years ago
69e760841a
Move should cancel blur into codecell
12 years ago
4fdc99e111
Remove notebook load log succes
12 years ago
a6f883d7f2
Couple of whiteboard logic implementation misses
12 years ago
9451589e38
implemented whiteboard logic
12 years ago
0884716a7d
Re-added widget textbox blur fix FF
12 years ago
bfc51c2a29
Final touches?
12 years ago
c5fb037e41
Reorg index and focus_editor params on edit_mode func
12 years ago
048ca30b0c
Remove fixes that are implemented correct in new CM
12 years ago
e847a31348
Always refresh the CM editor upon TextCell unrender.
12 years ago
b976804051
Moved edit_mode canceling logic back into cell.
12 years ago
ff37fb7a36
Standardized comments and removed last logs
12 years ago
64ae25508d
Removed change that is no longer needed
12 years ago
70086d352f
s/unfocus/blur
12 years ago
c7860d8bc8
Post in person review
...
Removed logic for reverse ordered events
Removed almost all of the log statements
Removed list for should unfocus callbacks
Removed all the logic in focus_editor
Only call focus_editor if the keyboard was used to enter edit mode
12 years ago
3595c099c2
Fixed rebase problems
12 years ago
10d79a9102
Added cell unfocus event canceller API
12 years ago
a6aaa8a886
Use is_focused for element kbman removal event
12 years ago
6f7c502157
Fixed lots of bugs
...
Half overhaul of notebook focus events...
12 years ago
206d35a89e
DEBUG
...
Added lots of log calls and a couple small 'fixes' (attempts)
12 years ago
7913305312
jshint
12 years ago
bdde544d47
don't forget base_url when updating address bar in rename
12 years ago
6c1ef48f1a
Merge pull request #5173 from jdfreder/movewidgets
...
Moved widget files into static/widgets/*
12 years ago
0117b587ab
Merge pull request #4985 from damianavila/closebrackets
...
Enable autoCloseBrackets in CodeMirror by default.
12 years ago
371afec677
Merge pull request #5112 from minrk/completion-band-aid
...
Band-aid for completion in the notebook: not the ideal solution, but will have to do the job for now so that typing while completing works.
closes #4860
12 years ago
edb8d68331
Merge pull request #5132 from minrk/oops-pdf-transform
...
remove application/pdf->pdf transform in javascript
12 years ago
28423647a2
Updated require references to point to new files
12 years ago
e0ba52c802
Moved widget files into static/widgets/*
...
Since they do not depend on anything ntoebook related
12 years ago
612acd2e08
Merge pull request #5170 from jdfreder/widget-throttle-trait
...
Added msg_throttle sync=True widget traitlet
12 years ago
eda4569099
Merge pull request #5037 from jdfreder/ff-widget-align
...
FF Fix: alignment and scale of text widget
12 years ago
ef3f61f906
Use set_rendered to set the error msg of the cell.
12 years ago
946212d5fa
Treat set_rendered as unsafe.
12 years ago
407fc0a017
s/with with/with
12 years ago
6a224d131b
Move todos into set_rendered
12 years ago
db4960769b
Merge pull request #5100 from minrk/base_kernel_url
...
remove base_kernel_url
12 years ago
ad03225cf6
Audit .html() calls take #2
12 years ago
0e56051a01
Added parentheses to emphasize order of op.
12 years ago
0eebd9e05b
Added msg_throttle sync=True widget traitlet
12 years ago
3b8beec541
Added a class for RadioButtons container
...
with appropriate top padding...
12 years ago
033ea6d88c
Added bottom margin to text widget
12 years ago
efc01b8854
remove append_json reference
...
we never had such a method
12 years ago
a7fb5e1e55
Merge pull request #5114 from minrk/empty-button
...
use non-breaking space for button with no description
12 years ago
ea8896399b
remove application/pdf->pdf transform in javascript
...
We have the old transforms because they were added before we realized it was a bad idea. We should not add new ones.
12 years ago
59d3a8ff5f
handle empty string in ToggleButtonsWidget
12 years ago
0eff2bb651
handle space-only strings, not just zero-length
12 years ago
c50096334c
use non-breaking space for button with no description
...
to preserve button's size
reverses some inappropriate replacements of .html with .text.
closes #5113
12 years ago
fd346d1790
fix remove event in KeyboardManager.register_events
...
only call enable on remove when focused.
fixes a bug where command mode could be entered inappropriately
when non-focused elements are removed from the page
(see first `@interact` example).
12 years ago
a1e263785c
band-aid for completion
...
Unlike @Carreau's attempt at using proper CodeMirror completion,
this is just a band-aid to get the existing completion back to working for 2.0.
This adds a keypress handler on the completer,
which then calls insert with the charCode of the key press event,
replacing the final `elif` branch of the keydown handler.
This cannot be done with keydown,
since keydown doesn't know what character is incoming,
only the hardware key that is struck.
12 years ago
a184724bdb
remove base_kernel_url
12 years ago
24c27ce5e5
Merge pull request #5059 from jdfreder/widgets-patch-fix
...
Fix incorrect `Patch` logic in widget code
12 years ago
1c564131c5
Fixed, set on recieve update triggering echos.
12 years ago
7b2787e508
Fixed typo
12 years ago
f4f2c92285
Keep a running diff instead of forcing a full state update
12 years ago
770d2bd3a0
Only send diff message if diff isn't corrupt.
...
Diff will corrupt if more then one model.set(...) call is made
before model.save (or view.touch() in our case).
12 years ago
5667947f9d
Revert "Let backbone get changed attrs"
...
This reverts commit 4dd4990ff146508894353e390601c659d2638ed3.
12 years ago
36b576b0bd
Let backbone get changed attrs
12 years ago
cd72883fc7
Revert "Fix incorrect usage of attrs"
...
This reverts commit 04aa0885bb143fd0409fe133ca572004ffa6dc0e.
12 years ago
0d80363240
Fix incorrect usage of attrs
12 years ago
81f37ab49f
Added align-start to widget container.
12 years ago
b7326707da
output_scroll can't be a vbox.
12 years ago
59eb13d80d
Align-start widget subarea
12 years ago
a93040e810
s/get_data/get_body_data/
12 years ago
e7db8cfd4e
fix notebook_path in menu bar
12 years ago
e1e0b19a6a
s/base_project_url/base_url/
...
deprecate NotebookApp.base_project_url
12 years ago
24703985e9
only add .ipynb if extension is not included
...
prevents .ipynb.ipynb double extension
12 years ago
61b06a39e2
holy crap, semicolons
12 years ago
13fc9022d9
various unicode fixes
...
- remove notebookPath, notebookName, and baseProjectUrl methods everywhere
- use base_project_url *attributes* instead
- we should never use escaped URLs except when making an actual request
Should fix issues with double-escaping
12 years ago
d3567f4cb0
Merge pull request #4920 from ellisonbg/pdf-formatter
...
Adding PDFFormatter and kernel side handling of PDF display data
12 years ago
fc6b68a8aa
Merge pull request #5048 from ellisonbg/modal-indicator
...
Add edit/command mode indicator
12 years ago
9b21f618e6
Merge pull request #5061 from minrk/execute-button
...
make execute button in menu bar match shift-enter
12 years ago
5a087f2a66
To the most conservative choice.
12 years ago
31301c4194
Just close the pager with q, not toggle.
12 years ago
4e37e901d8
Add q to toggle the pager.
12 years ago
24ef1be736
make execute button in menu bar match shift-enter
...
Noticed this when testing the UI on the IPad.
I expected the button to perform the default execute behavior,
but it doesn't.
12 years ago
2d973d2b14
Merge pull request #5051 from jdfreder/ff-hscroll2
...
FF Fix: code cell missing hscroll (2)
12 years ago
7032e9ef69
set overflow-x: hidden on Firefox only
...
workaround crazy Firefox-only behavior when selecting newlines
closes #3549
Conflicts:
IPython/html/static/style/style.min.css
12 years ago
445f6225e8
Spinning sun + nothing for command mode.
12 years ago
2b4559513d
Adding basic append_pdf in OutputArea.
12 years ago
5e5aecb4c2
Revert #3552
12 years ago
0ec796cfc7
Removed #4986
12 years ago
2d1f3c86d1
Delete old timeout.
12 years ago
af884b797f
Add edit/command mode indicator.
12 years ago
62d118afc7
Clear timeout in multi-press keyboard shortcuts.
12 years ago
2b248d65b0
Merge pull request #5035 from jdfreder/ff-hscroll
...
FF Fix: code cell missing hscroll
12 years ago
65fba24d92
FF Fix: make ext icon same line as txt
12 years ago
635fc4fbe2
FF Fix: missing scrollbars on inner_cells
12 years ago
a5feb922a3
Merge pull request #4774 from Carreau/emit-output
...
emit event on appended element on dom
12 years ago
e765f894b6
Merge pull request #5023 from jdfreder/widget-arrays
...
Widgets- add ability to pack and unpack arrays on JS side.
12 years ago
2c5db865d4
Merge pull request #4974 from ivanov/better-paste
...
make paste focus the pasted cell
12 years ago
350705075b
Merge pull request #5012 from minrk/selection-dict
...
Make `SelectionWidget.values` a dict
12 years ago
818f5e7824
Added ability to pack and unpack arrays.
12 years ago
0cb4a450a6
Merge pull request #5014 from jdfreder/widget-popup-keys
...
Fix command mode & popup view bug
12 years ago
4a314ea3da
Unconditionally register $el with keyboard manager
...
also s/elements/additional_elements
12 years ago
bb27cd0de5
more subtle kernel indicator
...
add casper.wait_for_busy
like wait_for_idle, but busy
restore kernel notification widget
it's still used for interrupt / restart
use wait_for_busy in check_interrupt test
12 years ago
3e1f2e22f8
Make `SelectionWidget.values` a dict
...
rename 'labels' and '_value' to 'value_names' and 'value_name'.
To specify a mapping of value names and values, use a dict.
If you specify `values=[list]`, then an OrderedDict will be used.
Assignment after construction only supports a dict.
12 years ago
ef2c71c34d
Fix command mode & popup view bug
...
Added elements property to PopupView
12 years ago
0ec7cf1b30
Merge pull request #5010 from jdfreder/widget-ff
...
Fixes for widget alignment in FF
12 years ago
1ddceb3844
Container classes should default with 'vbox' css
12 years ago
b20466386c
fix width overriden by 04abbe99
12 years ago
2b7310f794
Merge pull request #4933 from jdfreder/widget-model-name
...
Small Widget inconsistency fixes
12 years ago
91054043c0
Merge pull request #4979 from minrk/clear-output-msgspec
...
add versioning notes to small message spec changes
12 years ago
5fc70a924d
Merge pull request #4982 from ellisonbg/slider-readout
...
Live readout for slider widgets
12 years ago
fae8b28ba8
Merge pull request #4813 from Carreau/help-link
...
make help menu a template
12 years ago
0f86d8c909
Merge pull request #4964 from ptone/merge-above
...
remove shift-= merge keyboard shortcut
12 years ago
1d1e3b3932
remove alternate merge down shortcut
...
as shift+m is universal and sufficient
12 years ago
6ced0bcbac
Added automatic close of Brackets.
12 years ago
03b5e0b2e0
put OutputArea map at the end
12 years ago
38807bb59f
make help menu a templates
...
add splitline after keyboard shortcut
float external-link icon to the right
and move the 'title' to the individual elements,
so it follows hover.
12 years ago
651599d092
Finishing the readout style and functionality.
12 years ago
cef93c8cfb
Adding initial version of readout to sliders.
12 years ago
fbece64242
Merge pull request #4929 from ellisonbg/modal-fixes
...
Fixing various modal/focus related bugs
closes #4809
closes #4951
12 years ago
003c5e8eda
Merge pull request #4971 from ellisonbg/testjs-fd
...
Fixing issues with js tests
12 years ago
82a4538759
Notebook.delete should take no args.
12 years ago
1b74ee0c3e
note v4.1 msg spec change in clear_output handler
12 years ago
836fd887dc
make paste focuses the pasted cell
...
This is to make paste behave in the same manner that insert cell above
and below currently work (inserting a new item causes that item to
receive focus).
This solves a problem where, if a user pastes below a cell whose bottom
edge is below the current viewing area, they have no indication that any
action has occurred. The same applies for paste above a cell whose top
edge is occluded.
12 years ago
aa71651468
Fixing issues with js tests.
...
* Closing old pages to prevent fd leaks.
* Making sure kernels are killed to prevent fd leaks.
* Moving towards deleting old notebooks (this is not done, but
this should be merged as is).
12 years ago
7f9ee9cba7
Merge pull request #4916 from ellisonbg/modalbehavior
...
Fine tuning the behavior of the modal UI
swap back shift- and ctrl-enter, to their rightful places.
12 years ago
699bfcc709
Fix error message typo on web socket fail
12 years ago
547316fec3
Fixed typos in quick-help text
12 years ago
e2c20e0675
Rename _handle_new_view->_handle_display_view.
12 years ago
6298b16a44
Fixing help strings for shift|ctrl+enter.
12 years ago
dbed35c5b1
shift+enter and ctrl+enter swapped.
12 years ago
bcd4209375
alt+enter should always insert below
12 years ago
4c7ce61011
Don't enter edit mode when changing cell type and preserve renderd.
12 years ago
8c046fef99
Only call register_events on top level widget.
12 years ago
36ca1b0baf
Dont' force command mode in kbm.register_events.
12 years ago
63ae9e2fd7
Fixing this->that.
12 years ago
5f4d4017c1
Only call CM.focus() if CM is not already focused.
12 years ago
888698e12f
Merge pull request #4662 from ellisonbg/menu-cleanup
...
Menu cleanup
12 years ago
7c722d4b6c
Merge pull request #4824 from minrk/sign-notebooks
...
sign notebooks
12 years ago
6f3ef63ac9
s/Underscore/_
12 years ago
ffe92842fc
Merge pull request #4853 from minrk/imgmd
...
fix setting image height/width from metadata
12 years ago
Paul Ivanov
Brian E. Granger
Jonathan Frederic
Min RK
Thomas Kluyver
juhasch
Fernando Perez
Jonathan Frederic
Matthias BUSSONNIER
Paul Ivanov
Preston Holmes
damianavila
Kieran O'Mahony