You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

85 lines
2.7 KiB

# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
import logging
[python] return more errors when external commands fail Summary: Better to bail early than have mysterious failures. These used to have the wrong error messages: ``` $ cd examples/android_hello/ $ infer -- ./gradlew rubbish Capturing in gradle mode... Running and capturing gradle compilation... 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] FAILURE: Build failed with an exception. 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * What went wrong: 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Task 'rubbish' not found in root project 'android_hello'. 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * Try: 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Nothing to compile. Try running `./gradlew clean` first. ERROR: (Unix.Exit_or_signal (Exit_non_zero 66)) $ cd - $ infer --flavors --Xbuck --keep-going -- buck build //toto:toto Capturing in buck mode... moving files in buck-out to buck-out/.trash/buck-outwiiL6N Not using buckd because watchman isn't installed. BUILD FAILED: No build file at toto/BUCK when resolving target //toto:toto#infer. Buck failed, but continuing the analysis because --keep-going was passed Not using buckd because watchman isn't installed. No build file at toto/BUCK when resolving target //toto:toto#infer. Traceback (most recent call last): File "/home/jul/infer/infer/bin/../lib/python/infer.py", line 186, in <module> main() File "/home/jul/infer/infer/bin/../lib/python/infer.py", line 168, in main capture_exitcode = imported_module.gen_instance(args, cmd).capture() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 89, in capture return self.capture_with_flavors() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 242, in capture_with_flavors result_paths = self._get_analysis_result_paths() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 148, in _get_analysis_result_paths out = [x.split(None, 1)[1] for x in buck_output.strip().split('\n')] IndexError: list index out of range ERROR: (Unix.Exit_or_signal (Exit_non_zero 1)) $ cd infer/build_systems/ant/ && infer -- ant rubbish Capturing in ant mode... BUILD FAILED Target "rubbish" does not exist in the project "null". at org.apache.tools.ant.Project.tsort(Project.java:1929) at org.apache.tools.ant.Project.topoSort(Project.java:1837) at org.apache.tools.ant.Project.topoSort(Project.java:1800) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:857) at org.apache.tools.ant.Main.startAnt(Main.java:236) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) Total time: 0 seconds Nothing to compile. Try running `ant clean` first. ERROR: (Unix.Exit_or_signal (Exit_non_zero 66)) ``` Now we fail better, for instance: ``` $ infer --flavors --Xbuck --keep-going -- buck build //toto:toto Capturing in buck mode... moving files in buck-out to buck-out/.trash/buck-outHag8Ji Not using buckd because watchman isn't installed. BUILD FAILED: No build file at toto/BUCK when resolving target //toto:toto#infer. Buck failed, but continuing the analysis because --keep-going was passed Not using buckd because watchman isn't installed. No build file at toto/BUCK when resolving target //toto:toto#infer. ERROR: (Unix.Exit_or_signal (Exit_non_zero 70)) $ cd infer/build_systems/ant/ && infer -- ant rubbish Capturing in ant mode... BUILD FAILED Target "rubbish" does not exist in the project "null". at org.apache.tools.ant.Project.tsort(Project.java:1929) at org.apache.tools.ant.Project.topoSort(Project.java:1837) at org.apache.tools.ant.Project.topoSort(Project.java:1800) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:857) at org.apache.tools.ant.Main.startAnt(Main.java:236) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) Total time: 0 seconds ERROR: couldn't run compilation command `['ant', '-verbose', u'rubbish']` ERROR: (Unix.Exit_or_signal (Exit_non_zero 1)) ``` Reviewed By: jeremydubreil Differential Revision: D5469607 fbshipit-source-id: a3eb05c
7 years ago
import os
from . import util
from inferlib import jwlib
MODULE_NAME = __name__
MODULE_DESCRIPTION = '''Run analysis of code built with a command like:
ant [options] [target]
Analysis examples:
infer -- ant compile'''
LANG = ['java']
def gen_instance(*args):
return AntCapture(*args)
# This creates an empty argparser for the module, which provides only
# description/usage information and no arguments.
create_argparser = util.base_argparser(MODULE_DESCRIPTION, MODULE_NAME)
class AntCapture:
def __init__(self, args, cmd):
self.args = args
util.log_java_version()
logging.info(util.run_cmd_ignore_fail([cmd[0], '-version']))
# TODO: make the extraction of targets smarter
self.build_cmd = [cmd[0], '-verbose'] + cmd[1:]
def is_interesting(self, content):
return self.is_quoted(content) or content.endswith('.java')
def is_quoted(self, argument):
quote = '\''
return len(argument) > 2 and argument[0] == quote\
and argument[-1] == quote
def remove_quotes(self, argument):
if self.is_quoted(argument):
return argument[1:-1]
else:
return argument
def get_infer_commands(self, verbose_output):
javac_pattern = '[javac]'
argument_start_pattern = 'Compilation arguments'
calls = []
javac_arguments = []
collect = False
for line in verbose_output.split('\n'):
if javac_pattern in line:
if argument_start_pattern in line:
collect = True
if javac_arguments != []:
capture = jwlib.create_infer_command(javac_arguments)
calls.append(capture)
javac_arguments = []
if collect:
pos = line.index(javac_pattern) + len(javac_pattern)
content = line[pos:].strip()
if self.is_interesting(content):
arg = self.remove_quotes(content)
javac_arguments.append(arg)
if javac_arguments != []:
capture = jwlib.create_infer_command(javac_arguments)
calls.append(capture)
javac_arguments = []
return calls
def capture(self):
(code, (verbose_out, _)) = util.get_build_output(self.build_cmd)
[python] return more errors when external commands fail Summary: Better to bail early than have mysterious failures. These used to have the wrong error messages: ``` $ cd examples/android_hello/ $ infer -- ./gradlew rubbish Capturing in gradle mode... Running and capturing gradle compilation... 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] FAILURE: Build failed with an exception. 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * What went wrong: 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Task 'rubbish' not found in root project 'android_hello'. 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * Try: 10:46:56.730 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Nothing to compile. Try running `./gradlew clean` first. ERROR: (Unix.Exit_or_signal (Exit_non_zero 66)) $ cd - $ infer --flavors --Xbuck --keep-going -- buck build //toto:toto Capturing in buck mode... moving files in buck-out to buck-out/.trash/buck-outwiiL6N Not using buckd because watchman isn't installed. BUILD FAILED: No build file at toto/BUCK when resolving target //toto:toto#infer. Buck failed, but continuing the analysis because --keep-going was passed Not using buckd because watchman isn't installed. No build file at toto/BUCK when resolving target //toto:toto#infer. Traceback (most recent call last): File "/home/jul/infer/infer/bin/../lib/python/infer.py", line 186, in <module> main() File "/home/jul/infer/infer/bin/../lib/python/infer.py", line 168, in main capture_exitcode = imported_module.gen_instance(args, cmd).capture() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 89, in capture return self.capture_with_flavors() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 242, in capture_with_flavors result_paths = self._get_analysis_result_paths() File "/home/jul/infer/infer/lib/python/inferlib/capture/buck.py", line 148, in _get_analysis_result_paths out = [x.split(None, 1)[1] for x in buck_output.strip().split('\n')] IndexError: list index out of range ERROR: (Unix.Exit_or_signal (Exit_non_zero 1)) $ cd infer/build_systems/ant/ && infer -- ant rubbish Capturing in ant mode... BUILD FAILED Target "rubbish" does not exist in the project "null". at org.apache.tools.ant.Project.tsort(Project.java:1929) at org.apache.tools.ant.Project.topoSort(Project.java:1837) at org.apache.tools.ant.Project.topoSort(Project.java:1800) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:857) at org.apache.tools.ant.Main.startAnt(Main.java:236) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) Total time: 0 seconds Nothing to compile. Try running `ant clean` first. ERROR: (Unix.Exit_or_signal (Exit_non_zero 66)) ``` Now we fail better, for instance: ``` $ infer --flavors --Xbuck --keep-going -- buck build //toto:toto Capturing in buck mode... moving files in buck-out to buck-out/.trash/buck-outHag8Ji Not using buckd because watchman isn't installed. BUILD FAILED: No build file at toto/BUCK when resolving target //toto:toto#infer. Buck failed, but continuing the analysis because --keep-going was passed Not using buckd because watchman isn't installed. No build file at toto/BUCK when resolving target //toto:toto#infer. ERROR: (Unix.Exit_or_signal (Exit_non_zero 70)) $ cd infer/build_systems/ant/ && infer -- ant rubbish Capturing in ant mode... BUILD FAILED Target "rubbish" does not exist in the project "null". at org.apache.tools.ant.Project.tsort(Project.java:1929) at org.apache.tools.ant.Project.topoSort(Project.java:1837) at org.apache.tools.ant.Project.topoSort(Project.java:1800) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:857) at org.apache.tools.ant.Main.startAnt(Main.java:236) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) Total time: 0 seconds ERROR: couldn't run compilation command `['ant', '-verbose', u'rubbish']` ERROR: (Unix.Exit_or_signal (Exit_non_zero 1)) ``` Reviewed By: jeremydubreil Differential Revision: D5469607 fbshipit-source-id: a3eb05c
7 years ago
if code != os.EX_OK:
return code
cmds = self.get_infer_commands(verbose_out)
return util.run_compilation_commands(cmds)