[Infer][nullables] Temporarily disabling warnings on nullable fields

master
Sam Blackshear 9 years ago
parent f9939786fb
commit 089abea3d7

@ -943,7 +943,8 @@ let check_dereference_error pdesc (prop : Prop.normal Prop.t) lexp loc =
when Sil.exp_equal exp deref_exp && Annotations.param_is_nullable pvar ann_sig -> when Sil.exp_equal exp deref_exp && Annotations.param_is_nullable pvar ann_sig ->
nullable_obj_str := Sil.pvar_to_string pvar; nullable_obj_str := Sil.pvar_to_string pvar;
true true
| Sil.Hpointsto (_, Sil.Estruct (flds, inst), Sil.Sizeof (typ, _)) -> (* TODO: (t7970552) re-enable checks on @Nullable fields *)
(*| Sil.Hpointsto (_, Sil.Estruct (flds, inst), Sil.Sizeof (typ, _)) ->
let is_nullable fld = let is_nullable fld =
match Annotations.get_field_type_and_annotation fld typ with match Annotations.get_field_type_and_annotation fld typ with
| Some (_, annot) -> Annotations.ia_is_nullable annot | Some (_, annot) -> Annotations.ia_is_nullable annot
@ -954,7 +955,7 @@ let check_dereference_error pdesc (prop : Prop.normal Prop.t) lexp loc =
nullable_obj_str := Ident.fieldname_to_simplified_string fld; nullable_obj_str := Ident.fieldname_to_simplified_string fld;
true true
| _ -> false in | _ -> false in
list_exists is_strexp_pt_by_nullable_fld flds list_exists is_strexp_pt_by_nullable_fld flds*)
| _ -> false) | _ -> false)
(Prop.get_sigma prop) in (Prop.get_sigma prop) in
let root = Sil.root_of_lexp lexp in let root = Sil.root_of_lexp lexp in

@ -55,7 +55,8 @@ public class NullPointerExceptionTest {
"cursorFromContentResolverNPE", "cursorFromContentResolverNPE",
"nullPointerExceptionInArrayLengthLoop", "nullPointerExceptionInArrayLengthLoop",
"nullPointerExceptionCallArrayReadMethod", "nullPointerExceptionCallArrayReadMethod",
"nullableFieldNPE", // TODO (t7970552): re-enable this test
//"nullableFieldNPE",
"nullableParamNPE", "nullableParamNPE",
"badCheckShouldCauseNPE", "badCheckShouldCauseNPE",
"nullPointerExceptionArrayLength", "nullPointerExceptionArrayLength",

Loading…
Cancel
Save