[cost] Register forgotten expensive issue

Reviewed By: da319

Differential Revision: D24921179

fbshipit-source-id: 098cc3d58
master
Ezgi Çiçek 4 years ago committed by Facebook GitHub Bot
parent 10e921bcec
commit 14b32f1727

@ -452,6 +452,8 @@ OPTIONS
EXECUTION_TIME_COMPLEXITY_INCREASE_UI_THREAD (enabled by
default),
EXECUTION_TIME_UNREACHABLE_AT_EXIT (disabled by default),
EXPENSIVE_AUTORELEASEPOOL_SIZE (disabled by default),
EXPENSIVE_EXECUTION_TIME (disabled by default),
EXPENSIVE_LOOP_INVARIANT_CALL (enabled by default),
EXPOSED_INSECURE_INTENT_HANDLING (enabled by default),
Failure_exe (enabled by default),

@ -160,6 +160,8 @@ OPTIONS
EXECUTION_TIME_COMPLEXITY_INCREASE_UI_THREAD (enabled by
default),
EXECUTION_TIME_UNREACHABLE_AT_EXIT (disabled by default),
EXPENSIVE_AUTORELEASEPOOL_SIZE (disabled by default),
EXPENSIVE_EXECUTION_TIME (disabled by default),
EXPENSIVE_LOOP_INVARIANT_CALL (enabled by default),
EXPOSED_INSECURE_INTENT_HANDLING (enabled by default),
Failure_exe (enabled by default),

@ -452,6 +452,8 @@ OPTIONS
EXECUTION_TIME_COMPLEXITY_INCREASE_UI_THREAD (enabled by
default),
EXECUTION_TIME_UNREACHABLE_AT_EXIT (disabled by default),
EXPENSIVE_AUTORELEASEPOOL_SIZE (disabled by default),
EXPENSIVE_EXECUTION_TIME (disabled by default),
EXPENSIVE_LOOP_INVARIANT_CALL (enabled by default),
EXPOSED_INSECURE_INTENT_HANDLING (enabled by default),
Failure_exe (enabled by default),

@ -1005,5 +1005,6 @@ let is_autoreleasepool_size_issue =
List.iter [true; false] ~f:(fun is_on_ui_thread ->
add_autoreleasepool_size_issue ~kind (unreachable_cost_call ~kind) ;
add_autoreleasepool_size_issue ~kind (infinite_cost_call ~kind) ;
add_autoreleasepool_size_issue ~kind (expensive_cost_call ~kind) ;
add_autoreleasepool_size_issue ~kind (complexity_increase ~kind ~is_on_ui_thread) ) ) ;
fun issue_type -> IssueSet.mem issue_type !autoreleasepool_size_issues

Loading…
Cancel
Save