make liveness an `intraprocedural`

Summary: Making checkers/ its own dune library.

Reviewed By: ezgicicek

Differential Revision: D21407064

fbshipit-source-id: 49cd437a2

infer/src/backend/registerCheckers.ml

@@ -172,7 +172,7 @@ let all_checkers =
     ; callbacks= [(Procedure PrintfArgs.callback_printf_args, Language.Java)] }
   ; { name= "liveness"
     ; active= Config.is_checker_enabled Liveness
-    ; callbacks= [(Procedure Liveness.checker, Language.Clang)] }
+    ; callbacks= [(intraprocedural Liveness.checker, Language.Clang)] }
   ; { name= "inefficient keyset iterator"
     ; active= Config.is_checker_enabled InefficientKeysetIterator
     ; callbacks= [(intraprocedural InefficientKeysetIterator.checker, Language.Java)] }

infer/src/checkers/liveness.ml

@@ -92,7 +92,7 @@ module TransferFunctions (LConfig : LivenessConfig) (CFG : ProcCfg.S) = struct
   module CFG = CFG
   module Domain = Domain
 
-  type analysis_data = unit ProcData.t
+  type analysis_data = unit
 
   (** add all of the vars read in [exp] to the live set *)
   let exp_add_live exp astate =
@@ -122,7 +122,7 @@ module TransferFunctions (LConfig : LivenessConfig) (CFG : ProcCfg.S) = struct
         add_live_actuals_ actuals live_acc
 
 
-  let exec_instr astate _ _ = function
+  let exec_instr astate () _ = function
     | Sil.Load {id= lhs_id} when Ident.is_none lhs_id ->
         (* dummy deref inserted by frontend--don't count as a read *)
         astate
@@ -181,9 +181,9 @@ module CapturedByRefTransferFunctions (CFG : ProcCfg.S) = struct
   module CFG = CFG
   module Domain = VarSet
 
-  type analysis_data = unit ProcData.t
+  type analysis_data = unit
 
-  let exec_instr astate _ _ instr =
+  let exec_instr astate () _ instr =
     List.fold (Sil.exps_of_instr instr)
       ~f:(fun acc exp ->
         Exp.fold_captured exp
@@ -205,18 +205,15 @@ end
 module CapturedByRefAnalyzer =
   AbstractInterpreter.MakeRPO (CapturedByRefTransferFunctions (ProcCfg.Exceptional))
 
-let get_captured_by_ref_invariant_map proc_desc proc_data =
+let get_captured_by_ref_invariant_map proc_desc =
   let cfg = ProcCfg.Exceptional.from_pdesc proc_desc in
-  CapturedByRefAnalyzer.exec_cfg cfg proc_data ~initial:VarSet.empty
+  CapturedByRefAnalyzer.exec_cfg cfg () ~initial:VarSet.empty
 
 
-let checker {Callbacks.exe_env; summary} : Summary.t =
+let checker {IntraproceduralAnalysis.proc_desc; err_log} =
-  let proc_desc = Summary.get_proc_desc summary in
+  let captured_by_ref_invariant_map = get_captured_by_ref_invariant_map proc_desc in
-  let tenv = Exe_env.get_tenv exe_env (Summary.get_proc_name summary) in
-  let proc_data = {ProcData.summary; tenv; extras= ()} in
-  let captured_by_ref_invariant_map = get_captured_by_ref_invariant_map proc_desc proc_data in
   let cfg = CFG.from_pdesc proc_desc in
-  let invariant_map = CheckerAnalyzer.exec_cfg cfg proc_data ~initial:Domain.empty in
+  let invariant_map = CheckerAnalyzer.exec_cfg cfg () ~initial:Domain.empty in
   (* we don't want to report in harmless cases like int i = 0; if (...) { i = ... } else { i = ... }
      that create an intentional dead store as an attempt to imitate default value semantics.
      use dead stores to a "sentinel" value as a heuristic for ignoring this case *)
@@ -259,7 +256,8 @@ let checker {Callbacks.exe_env; summary} : Summary.t =
         (Typ.pp_full Pp.text) typ
     in
     let ltr = [Errlog.make_trace_element 0 loc "Write of unused value" []] in
-    SummaryReporting.log_error summary ~loc ~ltr IssueType.dead_store message
+    let attrs = Procdesc.get_attributes proc_desc in
+    Reporting.log_error attrs err_log ~loc ~ltr IssueType.dead_store message
   in
   let report_dead_store live_vars captured_by_ref_vars = function
     | Sil.Store {e1= Lvar pvar; typ; e2= rhs_exp; loc}
@@ -296,5 +294,4 @@ let checker {Callbacks.exe_env; summary} : Summary.t =
         | None ->
             () )
   in
-  Container.iter cfg ~fold:CFG.fold_nodes ~f:report_on_node ;
+  Container.iter cfg ~fold:CFG.fold_nodes ~f:report_on_node
-  summary

infer/src/checkers/liveness.mli

@@ -14,6 +14,6 @@ module PreAnalysisTransferFunctions (CFG : ProcCfg.S) :
   TransferFunctions.SIL
     with module CFG = CFG
      and module Domain = Domain
-     and type analysis_data = unit ProcData.t
+     and type analysis_data = unit
 
-val checker : Callbacks.proc_callback_args -> Summary.t
+val checker : IntraproceduralAnalysis.t -> unit

infer/src/checkers/preanal.ml

@@ -301,9 +301,7 @@ module Liveness = struct
   let process summary tenv =
     let liveness_proc_cfg = BackwardCfg.from_pdesc (Summary.get_proc_desc summary) in
     let initial = Liveness.Domain.empty in
-    let liveness_inv_map =
+    let liveness_inv_map = LivenessAnalysis.exec_cfg liveness_proc_cfg () ~initial in
-      LivenessAnalysis.exec_cfg liveness_proc_cfg {ProcData.summary; tenv; extras= ()} ~initial
-    in
     add_nullify_instrs summary tenv liveness_inv_map
 end
 

infer/src/unit/livenessTests.ml

@@ -97,8 +97,6 @@ let tests =
         ; While (unknown_cond, [id_assign_var "b" "d"])
         ; invariant "{ b }"
         ; id_assign_var "a" "b" ] ) ]
-    |> TestInterpreter.create_tests
+    |> TestInterpreter.create_tests (fun _summary -> ()) ~initial:Liveness.Domain.empty
-         (fun summary -> {ProcData.summary; tenv= Tenv.create (); extras= ()})
-         ~initial:Liveness.Domain.empty
   in
   "liveness_test_suite" >::: test_list