[uninit/pulse] Enable uninit/pulse issue by defualt

Summary: This diff enables uninit/pulse and disables the previous uninit checker by default.

Reviewed By: ngorogiannis

Differential Revision: D28870315

fbshipit-source-id: 323b6bab1

infer/man/man1/infer-analyze.txt

@@ -125,8 +125,7 @@ OPTIONS
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --inefficient-keyset-iterator, --linters,
            --liveness, --racerd, --dotnet-resource-leak, --siof,
-           --self-in-block, --starvation, --uninit (Conversely:
+           --self-in-block, --starvation (Conversely: --default-checkers)
-           --default-checkers)
 
        --eradicate
            Activates: checker eradicate: The eradicate `@Nullable` checker
@@ -437,9 +436,9 @@ OPTIONS
            Activates: Enable topl and disable all other checkers (Conversely:
            --no-topl-only)
 
-       --no-uninit
+       --uninit
-           Deactivates: checker uninit: Warns when values are used before
+           Activates: checker uninit: Warns when values are used before
-           having been initialized. (Conversely: --uninit)
+           having been initialized. (Conversely: --no-uninit)
 
        --uninit-only
            Activates: Enable uninit and disable all other checkers

infer/man/man1/infer-full.txt

@@ -394,8 +394,8 @@ OPTIONS
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --inefficient-keyset-iterator, --linters,
            --liveness, --racerd, --dotnet-resource-leak, --siof,
-           --self-in-block, --starvation, --uninit (Conversely:
+           --self-in-block, --starvation (Conversely: --default-checkers)       
-           --default-checkers)           See also infer-analyze(1).
+    See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -552,7 +552,7 @@ OPTIONS
              PRECONDITION_NOT_FOUND (enabled by default),
              PRECONDITION_NOT_MET (enabled by default),
              PREMATURE_NIL_TERMINATION_ARGUMENT (enabled by default),
-             PULSE_UNINITIALIZED_VALUE (disabled by default),
+             PULSE_UNINITIALIZED_VALUE (enabled by default),
              PURE_FUNCTION (enabled by default),
              QUANDARY_TAINT_ERROR (enabled by default),
              RESOURCE_LEAK (enabled by default),
@@ -1299,9 +1299,9 @@ OPTIONS
            Activates: Enable topl and disable all other checkers (Conversely:
            --no-topl-only)           See also infer-analyze(1).
 
-       --no-uninit
+       --uninit
-           Deactivates: checker uninit: Warns when values are used before
+           Activates: checker uninit: Warns when values are used before
-           having been initialized. (Conversely: --uninit)           See also infer-analyze(1).
+           having been initialized. (Conversely: --no-uninit)           See also infer-analyze(1).
 
        --uninit-only
            Activates: Enable uninit and disable all other checkers

infer/man/man1/infer-report.txt

@@ -229,7 +229,7 @@ OPTIONS
              PRECONDITION_NOT_FOUND (enabled by default),
              PRECONDITION_NOT_MET (enabled by default),
              PREMATURE_NIL_TERMINATION_ARGUMENT (enabled by default),
-             PULSE_UNINITIALIZED_VALUE (disabled by default),
+             PULSE_UNINITIALIZED_VALUE (enabled by default),
              PURE_FUNCTION (enabled by default),
              QUANDARY_TAINT_ERROR (enabled by default),
              RESOURCE_LEAK (enabled by default),

infer/man/man1/infer.txt

@@ -394,8 +394,8 @@ OPTIONS
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --inefficient-keyset-iterator, --linters,
            --liveness, --racerd, --dotnet-resource-leak, --siof,
-           --self-in-block, --starvation, --uninit (Conversely:
+           --self-in-block, --starvation (Conversely: --default-checkers)       
-           --default-checkers)           See also infer-analyze(1).
+    See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -552,7 +552,7 @@ OPTIONS
              PRECONDITION_NOT_FOUND (enabled by default),
              PRECONDITION_NOT_MET (enabled by default),
              PREMATURE_NIL_TERMINATION_ARGUMENT (enabled by default),
-             PULSE_UNINITIALIZED_VALUE (disabled by default),
+             PULSE_UNINITIALIZED_VALUE (enabled by default),
              PURE_FUNCTION (enabled by default),
              QUANDARY_TAINT_ERROR (enabled by default),
              RESOURCE_LEAK (enabled by default),
@@ -1299,9 +1299,9 @@ OPTIONS
            Activates: Enable topl and disable all other checkers (Conversely:
            --no-topl-only)           See also infer-analyze(1).
 
-       --no-uninit
+       --uninit
-           Deactivates: checker uninit: Warns when values are used before
+           Activates: checker uninit: Warns when values are used before
-           having been initialized. (Conversely: --uninit)           See also infer-analyze(1).
+           having been initialized. (Conversely: --no-uninit)           See also infer-analyze(1).
 
        --uninit-only
            Activates: Enable uninit and disable all other checkers

infer/src/base/Checker.ml

@@ -441,11 +441,15 @@ let config_unsafe checker =
       ; activates= [Pulse] }
   | Uninit ->
       { id= "uninit"
-      ; kind= UserFacing {title= "Uninitialized Value"; markdown_body= ""}
+      ; kind=
+          UserFacingDeprecated
+            { title= "Uninitialized Value"
+            ; markdown_body= ""
+            ; deprecation_message= "Uninitialized value checking has moved to Pulse." }
       ; support= supports_clang
       ; short_documentation= "Warns when values are used before having been initialized."
       ; cli_flags= Some {deprecated= []; show_in_help= true}
-      ; enabled_by_default= true
+      ; enabled_by_default= false
       ; activates= [] }
 
 

infer/src/base/IssueType.ml

@@ -949,7 +949,7 @@ let uninitialized_value =
 
 
 let uninitialized_value_pulse =
-  register ~enabled:false ~id:"PULSE_UNINITIALIZED_VALUE" Error Pulse ~hum:"Uninitialized Value"
+  register ~id:"PULSE_UNINITIALIZED_VALUE" Error Pulse ~hum:"Uninitialized Value"
     ~user_documentation:
       "See [UNINITIALIZED_VALUE](#uninitialized_value). Re-implemented using Pulse."