[infer][Java] rename the builtin `InferBuiltins.__infer_assume` into `InferBuiltins.assume`

infer/models/java/src/com/facebook/infer/models/InferBuiltins.java

@@ -20,7 +20,8 @@ public class InferBuiltins {
     public static void _exit() {
     }
 
-    public static void __infer_assume(boolean condition) {
+    public static void assume(boolean condition) {
+      while (!condition) {}
     }
 
     public static String __split_get_nth(String s, String sep, int n) {

infer/models/java/src/com/facebook/infer/models/InferUndefined.java

@@ -6,10 +6,13 @@
 
 package com.facebook.infer.models;
 
+import com.facebook.infer.models.InferBuiltins;
+
 import java.io.IOException;
 import java.net.SocketException;
 import java.sql.SQLException;
 
+
 public class InferUndefined {
 
     public static native boolean boolean_undefined();
@@ -130,9 +133,7 @@ public class InferUndefined {
 
     public static int nonneg_int() {
         int res = int_undefined();
-        if (res < 0)
+        InferBuiltins.assume(res >= 0);
-            while (true) {
-            }
         return res;
     }
 

infer/models/java/src/com/google/common/collect/ImmutableList.java

@@ -1,12 +1,14 @@
 package com.google.common.collect;
 
+import com.facebook.infer.models.InferBuiltins;
+
 public class ImmutableList<E> {
 
   private static final ImmutableList<Object> EMPTY = new ImmutableList<Object>();
 
   @SuppressWarnings("unchecked")
   public static <E> ImmutableList<E> of() {
-    while (EMPTY == null) {}
+    InferBuiltins.assume(EMPTY != null);
     return (ImmutableList<E>) EMPTY;
   }
 

infer/models/java/src/com/google/common/collect/Iterators.java

@@ -2,6 +2,8 @@ package com.google.common.collect;
 
 import java.util.NoSuchElementException;
 
+import com.facebook.infer.models.InferBuiltins;
+
 import javax.annotation.Nullable;
 
 public class Iterators {
@@ -33,13 +35,12 @@ public class Iterators {
 
       @Override
       public T next() {
-        while (value == null) {}
+        InferBuiltins.assume(value != null);
         if (done) {
           throw new NoSuchElementException();
         }
         done = true;
         return value;
-//        return null;
       }
     };
   }

infer/tests/codetoanalyze/java/infer/JunitAssertion.java

@@ -9,7 +9,7 @@ public class JunitAssertion {
     }
   }
 
-  public void consistentAssumtion(A a) {
+  public void consistentAssertion(A a) {
     assertTrue(a != null);
     a.f();
   }

infer/tests/endtoend/java/infer/JunitAssertionTest.java

@@ -35,7 +35,7 @@ public class JunitAssertionTest {
         doesNotContain(
             NULL_DEREFERENCE,
             JunitAssertionFile,
-            "consistentAssumtion"
+            "consistentAssertion"
         )
     );
   }