[infer][java] the detection of a resource leak should not prevent the symbolic execution to proceed

Summary:
When detecting a resource leak, Infer used to raise an Leak exception and then prevent the specs to be computed for the paths containing a leak. This diff prevents resource leak to stop the analysis.

infer/src/backend/abs.ml

@@ -1333,8 +1333,8 @@ let check_junk ?original_prop pname tenv prop =
                 list_mem attr_opt_equal alloc_attribute !leaks_reported in
               let ignore_leak =
                 !Config.allowleak || ignore_resource || is_undefined || already_reported () in
-              (* in footprint mode, report leak and continue *)
-              let report_and_continue = !Config.footprint in
+              let report_and_continue =
+                !Sil.curr_language = Sil.Java || !Config.footprint in
               let report_leak () =
                 if not report_and_continue then raise exn
                 else

infer/tests/codetoanalyze/java/infer/CloseableAsResourceExample.java

@@ -16,17 +16,13 @@ import java.io.IOException;
 import java.io.StringReader;
 
 
-public class CloseableAsResourceExample {
-
-  native boolean star();
-
 class LocalException extends IOException {
 }
 
 class SomeResource implements Closeable {
 
   void doSomething() throws LocalException {
-        if (!star()) {
+    if (!CloseableAsResourceExample.star()) {
       throw new LocalException();
     }
   }
@@ -34,6 +30,41 @@ public class CloseableAsResourceExample {
   public void close() {}
 }
 
+class Resource implements Closeable {
+  public Resource() {
+  }
+  public void close() {}
+}
+
+class Wrapper implements Closeable {
+  Resource mR;
+  public Wrapper(Resource r) {
+    mR = r;
+  }
+  public void close() {
+    mR.close();
+  }
+}
+
+class Sub extends Wrapper {
+  public Sub(Resource r) {
+    super(r);
+  }
+}
+
+class ResourceWithException implements Closeable {
+
+  public void close() throws IOException {
+    if (CloseableAsResourceExample.star()) {
+      throw new IOException();
+    }
+  }
+}
+
+public class CloseableAsResourceExample {
+
+  native static boolean star();
+
   void closingCloseable() {
     SomeResource res = new SomeResource();
     res.close();
@@ -59,27 +90,6 @@ public class CloseableAsResourceExample {
     res.close();
   } // should report a resource leak
 
-  class Resource implements Closeable {
-    public Resource() {
-    }
-    public void close() {}
-  }
-
-  class Wrapper implements Closeable {
-    Resource mR;
-    public Wrapper(Resource r) {
-      mR = r;
-    }
-    public void close() {
-      mR.close();
-    }
-  }
-
-  class Sub extends Wrapper {
-    public Sub(Resource r) {
-      super(r);
-    }
-  }
 
   void closingWrapper() {
     Resource r = new Resource();
@@ -124,15 +134,6 @@ public class CloseableAsResourceExample {
     }
   }
 
-  class ResourceWithException implements Closeable {
-
-    public void close() throws IOException {
-      if (star()) {
-        throw new IOException();
-      }
-    }
-  }
-
   void noLeakwithExceptionOnClose() throws IOException {
     ResourceWithException res = new ResourceWithException();
     res.close();
@@ -143,4 +144,9 @@ public class CloseableAsResourceExample {
     Utils.closeQuietly(res);
   }
 
+  static T sourceOfNullWithResourceLeak() {
+    SomeResource r = new SomeResource();
+    return null;
+  }
+
 }

infer/tests/codetoanalyze/java/infer/NullPointerExceptions.java

@@ -335,10 +335,16 @@ public class NullPointerExceptions {
     }
   }
 
+
   void nullableNonNullStringAfterTextUtilsIsEmptyCheckShouldNotCauseNPE(@Nullable String str) {
     if (!TextUtils.isEmpty(str)) {
       str.length();
     }
   }
 
+  void someNPEAfterResourceLeak() {
+    T t = CloseableAsResourceExample.sourceOfNullWithResourceLeak();
+    t.f();
+  }
+
 }

infer/tests/endtoend/java/infer/CloseableAsResourceTest.java

@@ -42,6 +42,7 @@ public class CloseableAsResourceTest {
         "notClosingCloseable",
         "notClosingWrapper",
         "failToCloseWithCloseQuietly",
+        "sourceOfNullWithResourceLeak",
     };
     assertThat(
         "Results should not contain resource leak errors",

infer/tests/endtoend/java/infer/NullPointerExceptionTest.java

@@ -59,7 +59,8 @@ public class NullPointerExceptionTest {
         "nullableParamNPE",
         "badCheckShouldCauseNPE",
         "nullPointerExceptionArrayLength",
-        "npeWithDollars"
+        "npeWithDollars",
+        "someNPEAfterResourceLeak",
     };
     assertThat(
         "Results should contain " + NULL_DEREFERENCE,