[quandary] kill unused Source.to_return proc

Reviewed By: jvillard

Differential Revision: D3927750

fbshipit-source-id: a4047f4

infer/src/quandary/JavaTrace.ml

@@ -78,10 +78,6 @@ module JavaSource = struct
     | pname when Builtin.is_registered pname -> []
     | pname -> failwithf "Non-Java procname %a in Java analysis@." Procname.pp pname
 
-  (** make a clone of [t] with a new call site *)
-  let to_return t return_site =
-    { t with site = return_site; }
-
   let compare src1 src2 =
     SourceKind.compare src1.kind src2.kind
     |> next CallSite.compare src1.site src2.site

infer/src/quandary/Source.ml

@@ -16,8 +16,6 @@ module type S = sig
 
   val get_footprint_access_path: t -> AccessPath.t option
 
-  val to_return : t -> CallSite.t -> t
-
   (** ith return value * ith sink kind *)
   val get : CallSite.t -> (int * t) list
 end

infer/src/unit/TaintTests.ml

@@ -44,7 +44,6 @@ module MockTrace = Trace.Make(struct
       let is_footprint _ = assert false
       let make_footprint _ = assert false
       let get_footprint_access_path _ = assert false
-      let to_return _ _ = assert false
     end
 
     module Sink = struct

infer/src/unit/TraceTests.ml

@@ -67,7 +67,6 @@ module MockSource = struct
 
   let get _ = assert false
   let get_footprint_access_path _ = assert false
-  let to_return _ _ = assert false
 end
 
 module MockSink = struct