[infer] no longer run the annotation reachability and immutable cast checkers by default

Reviewed By: mbouaziz

Differential Revision: D14356832

fbshipit-source-id: 197f17a40

infer/man/man1/infer-analyze.txt

@@ -13,13 +13,13 @@ DESCRIPTION
 
 
 OPTIONS
-       --no-annotation-reachability
-           Deactivates: the annotation reachability checker. Given a pair of
+       --annotation-reachability
+           Activates: the annotation reachability checker. Given a pair of
            source and sink annotation, e.g. @PerformanceCritical and
            @Expensive, this checker will warn whenever some method annotated
            with @PerformanceCritical calls, directly or indirectly, another
            method annotated with @Expensive (Conversely:
-           --annotation-reachability)
+           --no-annotation-reachability)
 
        --annotation-reachability-only
            Activates: Enable --annotation-reachability and disable all other
@@ -97,10 +97,9 @@ OPTIONS
            values. (default: 0)
 
        --no-default-checkers
-           Deactivates: Default checkers: --annotation-reachability,
-           --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --racerd, --siof, --uninit
-           (Conversely: --default-checkers)
+           Deactivates: Default checkers: --biabduction,
+           --fragment-retains-view, --linters, --liveness, --ownership,
+           --racerd, --siof, --uninit (Conversely: --default-checkers)
 
        --eradicate
            Activates: the eradicate @Nullable checker for Java annotations
@@ -131,11 +130,11 @@ OPTIONS
            Show this manual with all internal options in the INTERNAL OPTIONS
            section
 
-       --no-immutable-cast
-           Deactivates: the detection of object cast from immutable type to
+       --immutable-cast
+           Activates: the detection of object cast from immutable type to
            mutable type. For instance, it will detect cast from ImmutableList
            to List, ImmutableMap to Map, and ImmutableSet to Set.
-           (Conversely: --immutable-cast)
+           (Conversely: --no-immutable-cast)
 
        --immutable-cast-only
            Activates: Enable --immutable-cast and disable all other checkers

infer/man/man1/infer-full.txt

@@ -54,13 +54,13 @@ OPTIONS
        supported options. The following is a list of all the supported
        options (see also --help-full for options reserved for internal use).
 
-       --no-annotation-reachability
-           Deactivates: the annotation reachability checker. Given a pair of
+       --annotation-reachability
+           Activates: the annotation reachability checker. Given a pair of
            source and sink annotation, e.g. @PerformanceCritical and
            @Expensive, this checker will warn whenever some method annotated
            with @PerformanceCritical calls, directly or indirectly, another
            method annotated with @Expensive (Conversely:
-           --annotation-reachability)           See also infer-analyze(1).
+           --no-annotation-reachability)           See also infer-analyze(1).
 
        --annotation-reachability-custom-pairs json
            Specify custom sources/sink for the annotation reachability
@@ -243,10 +243,10 @@ OPTIONS
            infer-reportdiff(1), and infer-run(1).
 
        --no-default-checkers
-           Deactivates: Default checkers: --annotation-reachability,
-           --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --racerd, --siof, --uninit
-           (Conversely: --default-checkers)           See also infer-analyze(1).
+           Deactivates: Default checkers: --biabduction,
+           --fragment-retains-view, --linters, --liveness, --ownership,
+           --racerd, --siof, --uninit (Conversely: --default-checkers)       
+    See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -417,11 +417,11 @@ OPTIONS
            Activates: Generate html report. (Conversely: --no-html)       
     See also infer-explore(1).
 
-       --no-immutable-cast
-           Deactivates: the detection of object cast from immutable type to
+       --immutable-cast
+           Activates: the detection of object cast from immutable type to
            mutable type. For instance, it will detect cast from ImmutableList
            to List, ImmutableMap to Map, and ImmutableSet to Set.
-           (Conversely: --immutable-cast)           See also infer-analyze(1).
+           (Conversely: --no-immutable-cast)           See also infer-analyze(1).
 
        --immutable-cast-only
            Activates: Enable --immutable-cast and disable all other checkers

infer/man/man1/infer.txt

@@ -54,13 +54,13 @@ OPTIONS
        supported options. The following is a list of all the supported
        options (see also --help-full for options reserved for internal use).
 
-       --no-annotation-reachability
-           Deactivates: the annotation reachability checker. Given a pair of
+       --annotation-reachability
+           Activates: the annotation reachability checker. Given a pair of
            source and sink annotation, e.g. @PerformanceCritical and
            @Expensive, this checker will warn whenever some method annotated
            with @PerformanceCritical calls, directly or indirectly, another
            method annotated with @Expensive (Conversely:
-           --annotation-reachability)           See also infer-analyze(1).
+           --no-annotation-reachability)           See also infer-analyze(1).
 
        --annotation-reachability-custom-pairs json
            Specify custom sources/sink for the annotation reachability
@@ -243,10 +243,10 @@ OPTIONS
            infer-reportdiff(1), and infer-run(1).
 
        --no-default-checkers
-           Deactivates: Default checkers: --annotation-reachability,
-           --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --racerd, --siof, --uninit
-           (Conversely: --default-checkers)           See also infer-analyze(1).
+           Deactivates: Default checkers: --biabduction,
+           --fragment-retains-view, --linters, --liveness, --ownership,
+           --racerd, --siof, --uninit (Conversely: --default-checkers)       
+    See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -417,11 +417,11 @@ OPTIONS
            Activates: Generate html report. (Conversely: --no-html)       
     See also infer-explore(1).
 
-       --no-immutable-cast
-           Deactivates: the detection of object cast from immutable type to
+       --immutable-cast
+           Activates: the detection of object cast from immutable type to
            mutable type. For instance, it will detect cast from ImmutableList
            to List, ImmutableMap to Map, and ImmutableSet to Set.
-           (Conversely: --immutable-cast)           See also infer-analyze(1).
+           (Conversely: --no-immutable-cast)           See also infer-analyze(1).
 
        --immutable-cast-only
            Activates: Enable --immutable-cast and disable all other checkers

infer/src/base/Config.ml

@@ -631,7 +631,7 @@ and ( annotation_reachability
     var
   in
   let annotation_reachability =
-    mk_checker ~default:true ~long:"annotation-reachability"
+    mk_checker ~default:false ~long:"annotation-reachability"
       "the annotation reachability checker. Given a pair of source and sink annotation, e.g. \
        @PerformanceCritical and @Expensive, this checker will warn whenever some method annotated \
        with @PerformanceCritical calls, directly or indirectly, another method annotated with \
@@ -648,7 +648,7 @@ and ( annotation_reachability
     mk_checker ~long:"fragment-retains-view" ~default:true
       "detects when Android fragments are not explicitly nullified before becoming unreabable"
   and immutable_cast =
-    mk_checker ~long:"immutable-cast" ~default:true
+    mk_checker ~long:"immutable-cast" ~default:false
       "the detection of object cast from immutable type to mutable type. For instance, it will \
        detect cast from ImmutableList to List, ImmutableMap to Map, and ImmutableSet to Set."
   and linters = mk_checker ~long:"linters" ~default:true "syntactic linters"