Reviewed By: peterogithub Differential Revision: D3318994 fbshipit-source-id: e36b927master
Sam Blackshear
9 years ago
committed by
Facebook Github Bot 7
parent
f259863090
commit
36ee3730aa
@ -1 +1 @@
|
||||
Subproject commit 3e46b786ad058c917a0cb23e9d26c5aaaed816be
|
||||
Subproject commit ba3d4b9066cc57c413581d2efe909add94b4366f
|
||||
@ -0,0 +1,103 @@
|
||||
/*
|
||||
* Copyright (c) 2016 - present Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
package codetoanalyze.java.infer;
|
||||
|
||||
import java.lang.annotation.ElementType;
|
||||
import java.lang.annotation.Retention;
|
||||
import java.lang.annotation.RetentionPolicy;
|
||||
import java.lang.annotation.Target;
|
||||
|
||||
public class GuardedByExample {
|
||||
|
||||
@Retention(RetentionPolicy.CLASS)
|
||||
@Target({ElementType.FIELD, ElementType.METHOD})
|
||||
public @interface GuardedBy {
|
||||
String value();
|
||||
}
|
||||
|
||||
private Object mLock = new Object();
|
||||
|
||||
private Object mOtherLock = new Object();
|
||||
|
||||
@GuardedBy("mLock")
|
||||
Object f = new Object();
|
||||
|
||||
@GuardedBy("this")
|
||||
Object g = new Object();
|
||||
|
||||
Object mCopyOfG;
|
||||
|
||||
@GuardedBy("SomeLockThatDoesntExist")
|
||||
Object h = new Object();
|
||||
|
||||
void readFBad() {
|
||||
this.f.toString();
|
||||
}
|
||||
|
||||
void readFBadWrongLock() {
|
||||
synchronized (mOtherLock) {
|
||||
this.f.toString(); // f is supposed to be protected by mLock
|
||||
}
|
||||
}
|
||||
|
||||
void readFAfterBlockBad() {
|
||||
synchronized (mLock) {
|
||||
}
|
||||
this.f.toString();
|
||||
}
|
||||
|
||||
@GuardedBy("mOtherLock")
|
||||
void readFBadWrongAnnotation() {
|
||||
this.f.toString();
|
||||
}
|
||||
|
||||
@GuardedBy("mLock")
|
||||
void readFOkMethodAnnotated() {
|
||||
this.f.toString();
|
||||
}
|
||||
|
||||
@GuardedBy("this")
|
||||
void guardedByThisOk() {
|
||||
this.g.toString();
|
||||
}
|
||||
|
||||
synchronized void synchronizedMethodOk() {
|
||||
this.g.toString();
|
||||
}
|
||||
|
||||
void readFOkSynchronized() {
|
||||
synchronized (mLock) {
|
||||
this.f.toString();
|
||||
}
|
||||
}
|
||||
|
||||
synchronized void synchronizedMethodBad() {
|
||||
this.f.toString(); // f is supposed to be protected by mLock, not this
|
||||
}
|
||||
|
||||
void readGFromCopyBad() {
|
||||
synchronized (this) {
|
||||
mCopyOfG = g; // these are ok: access of g guarded by this
|
||||
g.toString();
|
||||
}
|
||||
mCopyOfG.toString(); // should be an error; unprotected access to pt(g)
|
||||
}
|
||||
|
||||
void readHBad() {
|
||||
synchronized (mLock) { // h is not protected by mLock
|
||||
this.h.toString();
|
||||
}
|
||||
}
|
||||
|
||||
synchronized void readHBadSynchronizedMethodShouldntHelp() {
|
||||
this.h.toString(); // h is not protected by this
|
||||
}
|
||||
|
||||
}
|
||||
@ -0,0 +1,63 @@
|
||||
/*
|
||||
* Copyright (c) 2016 - present Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
package endtoend.java.infer;
|
||||
|
||||
import static org.hamcrest.MatcherAssert.assertThat;
|
||||
import static utils.matchers.ResultContainsExactly.containsExactly;
|
||||
|
||||
import org.junit.BeforeClass;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.io.IOException;
|
||||
|
||||
import utils.InferException;
|
||||
import utils.InferResults;
|
||||
|
||||
public class GuardedByTest {
|
||||
|
||||
public static final String SOURCE_FILE =
|
||||
"infer/tests/codetoanalyze/java/infer/GuardedByExample.java";
|
||||
|
||||
public static final String UNSAFE_GUARDED_BY_ACCESS = "UNSAFE_GUARDED_BY_ACCESS";
|
||||
|
||||
private static InferResults inferResults;
|
||||
|
||||
@BeforeClass
|
||||
public static void loadResults() throws InterruptedException, IOException {
|
||||
inferResults = InferResults.loadInferResults(
|
||||
GuardedByTest.class,
|
||||
SOURCE_FILE);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void matchErrors()
|
||||
throws IOException, InterruptedException, InferException {
|
||||
String[] methods = {
|
||||
"readFBad",
|
||||
"readFBadWrongLock",
|
||||
"readFAfterBlockBad",
|
||||
"readFBadWrongAnnotation",
|
||||
"synchronizedMethodBad",
|
||||
"readGFromCopyBad",
|
||||
"readHBad",
|
||||
"readHBadSynchronizedMethodShouldntHelp",
|
||||
};
|
||||
assertThat(
|
||||
"Results should contain " + UNSAFE_GUARDED_BY_ACCESS,
|
||||
inferResults,
|
||||
containsExactly(
|
||||
UNSAFE_GUARDED_BY_ACCESS,
|
||||
SOURCE_FILE,
|
||||
methods
|
||||
)
|
||||
);
|
||||
}
|
||||
|
||||
}
|
||||
Loading…
Reference in new issue