Summary: It is not used anywhere and there are no plans to revive it. Kill it! Reviewed By: skcho Differential Revision: D18934719 fbshipit-source-id: b9b069b96master
Ezgi Çiçek
5 years ago
committed by
Facebook Github Bot
parent
8ed2c77187
commit
47c89611a5
@ -1,66 +0,0 @@
|
||||
(*
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*)
|
||||
|
||||
open! IStd
|
||||
module F = Format
|
||||
module Domain = LithoDomain
|
||||
|
||||
(* return true if this is a graphql getter *)
|
||||
let is_graphql_function procname summary =
|
||||
Option.is_none summary
|
||||
(* we skip analysis of all GraphQL procs *)
|
||||
&&
|
||||
match procname with
|
||||
| Typ.Procname.Java java_procname -> (
|
||||
PatternMatch.is_getter java_procname
|
||||
&&
|
||||
match Typ.Procname.Java.get_package java_procname with
|
||||
| Some package ->
|
||||
String.is_prefix ~prefix:"com.facebook.graphql.model" package
|
||||
| None ->
|
||||
false )
|
||||
| _ ->
|
||||
false
|
||||
|
||||
|
||||
module LithoContext = struct
|
||||
type t = Domain.t
|
||||
|
||||
let check_callee ~callee_pname ~tenv:_ = is_graphql_function callee_pname
|
||||
|
||||
let satisfies_heuristic ~callee_pname:_ ~callee_summary_opt:_ _ = true
|
||||
|
||||
let field = Payloads.Fields.litho_graphql_field_access
|
||||
|
||||
let should_report proc_desc _tenv =
|
||||
LithoFramework.is_on_create_layout (Procdesc.get_proc_name proc_desc)
|
||||
|
||||
|
||||
let report astate _tenv summary =
|
||||
let report_graphql_getter access_path call_chain =
|
||||
let call_strings =
|
||||
List.map
|
||||
~f:(fun Domain.MethodCall.{procname} ->
|
||||
Typ.Procname.to_simplified_string ~withclass:false procname )
|
||||
call_chain
|
||||
in
|
||||
let call_string = String.concat ~sep:"." call_strings in
|
||||
let message = F.asprintf "%a.%s" AccessPath.pp access_path call_string in
|
||||
let loc = Summary.get_loc summary in
|
||||
let ltr = [Errlog.make_trace_element 0 loc message []] in
|
||||
Reporting.log_error summary ~loc ~ltr IssueType.graphql_field_access message
|
||||
in
|
||||
Domain.iter_call_chains ~f:report_graphql_getter astate ;
|
||||
astate
|
||||
|
||||
|
||||
let session_name = "litho graphql field access"
|
||||
end
|
||||
|
||||
module Analyzer = LithoFramework.MakeAnalyzer (LithoContext)
|
||||
|
||||
let checker callback = Analyzer.checker callback
|
||||
@ -1,97 +0,0 @@
|
||||
/*
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
// makes it easier to mock graphql types
|
||||
package com.facebook.graphql.model;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
abstract class A {
|
||||
abstract A getA();
|
||||
|
||||
abstract B getB();
|
||||
|
||||
abstract C getC();
|
||||
}
|
||||
|
||||
abstract class B {
|
||||
abstract C getC();
|
||||
}
|
||||
|
||||
abstract class C {
|
||||
abstract D getD();
|
||||
}
|
||||
|
||||
class D {}
|
||||
|
||||
abstract class GraphQLStory {
|
||||
|
||||
public abstract List getActors();
|
||||
}
|
||||
|
||||
class LithoTest {
|
||||
|
||||
void /*basic chain*/ onCreateLayout(A a) {
|
||||
a.getB().getC().getD();
|
||||
}
|
||||
|
||||
void /*sibling chain*/ onCreateLayout(A a, int i) {
|
||||
a.getB().getC().getD();
|
||||
a.getC().getD();
|
||||
}
|
||||
|
||||
void /*split chain*/ onCreateLayout(A a, int i1, int i2) {
|
||||
B b = a.getB();
|
||||
C c = b.getC();
|
||||
c.getD();
|
||||
}
|
||||
|
||||
void chainFromActual1(B b) {
|
||||
b.getC().getD();
|
||||
}
|
||||
|
||||
void chainFromActual2(C c) {
|
||||
c.getD();
|
||||
}
|
||||
|
||||
void /*chain rooted in actual*/ onCreateLayout(A a, boolean b) {
|
||||
chainFromActual1(a.getB());
|
||||
}
|
||||
|
||||
void /*local chain + interproc chain*/ onCreateLayout(A a, char ch) {
|
||||
C c = a.getB().getC();
|
||||
chainFromActual2(c);
|
||||
}
|
||||
|
||||
// conditional getters
|
||||
static GraphQLStory getPrimaryActor(GraphQLStory story) {
|
||||
List actors = story.getActors();
|
||||
return actors != null && actors.size() > 0 ? (GraphQLStory) actors.get(0) : null;
|
||||
}
|
||||
|
||||
void /*conditional getters on formal*/ onCreateLayout(GraphQLStory story) {
|
||||
getPrimaryActor(story).toString();
|
||||
}
|
||||
|
||||
static native GraphQLStory getStory();
|
||||
|
||||
void /*conditional getters on local*/ onCreateLayout() {
|
||||
GraphQLStory story = getStory();
|
||||
getPrimaryActor(story).toString();
|
||||
}
|
||||
|
||||
void /*cycle*/ onCreateLayout(A a, float f) {
|
||||
a = a.getA();
|
||||
}
|
||||
|
||||
void cycle(A a) {
|
||||
a = a.getA();
|
||||
}
|
||||
|
||||
void /*interprocedural cycle*/ onCreateLayout(A a, double d) {
|
||||
cycle(a);
|
||||
}
|
||||
}
|
||||
Loading…
Reference in new issue