[CK][Linter Rule] Add CKRenderLayoutWithChildren component to Component Kit Conventional Superclass

Reviewed By: kfirapps, ddino Differential Revision: D13590184 fbshipit-source-id: d4394839e
6 years ago · 499e6398b1
parent 28c3ed50de
commit 499e6398b1
4 changed files with 11 additions and 0 deletions
--- a/infer/src/clang/ComponentKit.ml
+++ b/infer/src/clang/ComponentKit.ml
@ -228,6 +228,7 @@ let component_with_unconventional_superclass_advice context an =
                     ; "CKCompositeComponent"
                     ; "CKRenderComponent"
                     ; "CKRenderLayoutComponent"
+                     ; "CKRenderLayoutWithChildrenComponent"
                     ; "CKRenderWithChildrenComponent"
                     ; "CKStatefulViewComponent"
                     ; "CKStatefulViewComponentController"
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/FakeComponentKitHeader.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/FakeComponentKitHeader.h
@ -70,3 +70,7 @@ class CKComponentScope {
 // Mimic importing CKRenderLayoutComponent
@interface CKRenderLayoutComponent : CKComponent
@end
+
+// Mimic importing CKRenderLayoutWithChildrenComponent
+@interface CKRenderLayoutWithChildrenComponent : CKComponent
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
@ -29,3 +29,6 @@

@interface RenderLayoutFooComponent : CKRenderLayoutComponent // good
@end
+
+@interface RenderLayoutWithChildrenFooComponent : CKRenderLayoutWithChildrenComponent // good
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
@ -26,3 +26,6 @@

@implementation RenderLayoutFooComponent
@end
+
+@implementation RenderLayoutWithChildrenFooComponent
+@end