[thread-safety] treat generated GraphQL constructors as returning ownership

Reviewed By: jeremydubreil

Differential Revision: D4552975

fbshipit-source-id: 199b01b

infer/src/checkers/ThreadSafety.ml

@@ -421,6 +421,18 @@ module TransferFunctions (CFG : ProcCfg.S) = struct
                         end
                     | _ ->
                         astate
+                  else if FbThreadSafety.is_graphql_constructor callee_pname
+                  then
+                    (* assume generated GraphQL code returns ownership *)
+                    match ret_opt with
+                    | Some (ret_id, ret_typ) ->
+                        let attribute_map =
+                          AttributeMapDomain.add_attribute
+                            (AccessPath.of_id ret_id ret_typ)
+                            Attribute.unconditionally_owned
+                            astate.attribute_map in
+                        { astate with attribute_map; }
+                    | None -> astate
                   else
                     astate in
         begin

infer/src/opensource/FbThreadSafety.ml

@@ -12,3 +12,5 @@ open! IStd
 let is_custom_init _ _  = false
 
 let is_logging_method _ = false
+
+let is_graphql_constructor _ = false

infer/src/opensource/FbThreadSafety.mli

@@ -12,3 +12,5 @@ open! IStd
 val is_custom_init : Tenv.t -> Procname.t -> bool
 
 val is_logging_method : Procname.t -> bool
+
+val is_graphql_constructor : Procname.t -> bool