[quandary] filter the footprint sources in Trace.should_report

Reviewed By: jberdine

Differential Revision: D4179763

fbshipit-source-id: a3e791a

infer/src/checkers/Source.ml

@@ -33,7 +33,8 @@ module Dummy = struct
 
   let pp _ () = ()
 
-  let is_footprint _ = assert false
+  let is_footprint _ = false
+
   let make_footprint _ _ = assert false
   let get_footprint_access_path _ = assert false
   let get _ = None

infer/src/checkers/Trace.ml

@@ -165,14 +165,22 @@ module Make (Spec : Spec) = struct
     Sources.is_empty t.sources
 
   let get_reports t =
-    if Sinks.is_empty t.sinks
+    if Sinks.is_empty t.sinks || Sources.is_empty t.sources
-    then []
+    then
+      []
     else
-      let report_one source sink acc =
+      (* written to avoid closure allocations in hot code. change with caution. *)
-        if Spec.should_report source sink
+      let report_source source sinks acc0 =
-        then (source, sink, t.passthroughs) :: acc
+        let report_one sink acc =
-        else acc in
+          if Spec.should_report source sink
-      Sources.fold (fun source acc -> Sinks.fold (report_one source) t.sinks acc) t.sources []
+          then (source, sink, t.passthroughs) :: acc
+          else acc in
+        Sinks.fold report_one sinks acc0 in
+      let report_sources source acc =
+        if Source.is_footprint source
+        then acc
+        else report_source source t.sinks acc in
+      Sources.fold report_sources t.sources []
 
   let pp_path cur_pname fmt (cur_passthroughs, sources_passthroughs, sinks_passthroughs) =
     let pp_passthroughs fmt passthroughs =

infer/src/unit/TaintTests.ml

@@ -45,7 +45,7 @@ module MockTrace = Trace.Make(struct
         then Some site
         else None
 
-      let is_footprint _ = assert false
+      let is_footprint _ = false
       let make_footprint _ = assert false
       let get_footprint_access_path _ = assert false
     end