Make warning 23 (Useless record with clause) fatal

Summary:
Enable warning 23 (Useless record with clause), make fatal, and fix the
existing instance.

Reviewed By: sblackshear

Differential Revision: D3685950

fbshipit-source-id: 8ee415d

infer/src/Makefile

@@ -19,7 +19,7 @@ ATDGEN_SUFFIXES = _t.ml _t.mli _j.ml _j.mli
 
 #### ocamlbuild options ####
 
-OCAML_FATAL_WARNINGS = +5+6+8+10+11+12+18+19+20+26+29+27+32+33+34+35+37+38+39+50
+OCAML_FATAL_WARNINGS = +5+6+8+10+11+12+18+19+20+23+26+29+27+32+33+34+35+37+38+39+50
 
 OCAMLBUILD_OPTIONS = \
                      -r \

infer/src/clang/cFrontend_errors.ml

@@ -162,7 +162,7 @@ let run_frontend_checkers_on_stmt context cfg cg method_decl instr =
       invoke_set_of_checkers call_checker context cfg cg decl_opt key while_stmt_checker_list;
       context
   | ObjCAtSynchronizedStmt _ ->
-      { context with CLintersContext.in_synchronized_block = true }
+      { (* context with *) CLintersContext.in_synchronized_block = true }
   | _ -> context
 
 let run_frontend_checkers_on_decl context cfg cg dec =