[driver] do not warn about nothing to analyze when not analyzing

Summary:
Sometimes we don't want to analyze but a message gets printed that there was
nothing to analyze and we exit with error, which is confusing.

Reviewed By: jberdine

Differential Revision: D4398120

fbshipit-source-id: 43ce3ab

infer/src/backend/infer.ml

@@ -319,19 +319,20 @@ let analyze = function
          separate Analyze invocation is necessary, depending on the buck flavor used. *)
       ()
   | _ ->
-      if (Sys.file_exists Config.(results_dir ^/ captured_dir_name)) <> `Yes then (
+      let should_analyze, should_report = match Config.analyzer with
-        L.stderr "There was nothing to analyze, exiting" ;
+        | Infer | Eradicate | Checkers | Tracing | Crashcontext | Quandary | Threadsafety ->
-        Config.print_usage_exit ()
+            true, true
+        | Linters ->
+            false, true
+        | Capture | Compile ->
+            false, false in
+      if (should_analyze || should_report)
+      && (Sys.file_exists Config.(results_dir ^/ captured_dir_name)) <> `Yes then (
+        L.stderr "There was nothing to analyze, exiting@." ;
+        exit 1
       );
-      (match Config.analyzer with
+      if should_analyze then execute_analyze ();
-       | Infer | Eradicate | Checkers | Tracing | Crashcontext | Quandary | Threadsafety ->
+      if should_report then report ()
-           execute_analyze () ;
-           report ()
-       | Linters ->
-           report ()
-       | Capture | Compile ->
-           ()
-      )
 
 (** as the Config.fail_on_bug flag mandates, exit with error when an issue is reported *)
 let fail_on_issue_epilogue () =