[quandary] support sources that taint a pointer arg or arg passed by ref rather than the return value
Summary: A lot of C++ library functions look like this, so it's important to have. Reviewed By: mbouaziz Differential Revision: D5026082 fbshipit-source-id: 6f421b6master
Sam Blackshear
8 years ago
committed by
Facebook Github Bot
parent
52ed886886
commit
6af6ef35ec
@ -0,0 +1,64 @@
|
||||
/*
|
||||
* Copyright (c) 2017 - present Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
#include <iostream>
|
||||
#include <fstream>
|
||||
#include <unistd.h>
|
||||
|
||||
namespace files {
|
||||
|
||||
void read_file_call_exec_bad1(int length) {
|
||||
std::ifstream is("test.txt", std::ifstream::binary);
|
||||
if (is) {
|
||||
char* buffer = new char[length];
|
||||
is.read(buffer, length);
|
||||
execle(buffer, NULL);
|
||||
is.close();
|
||||
}
|
||||
}
|
||||
|
||||
void read_file_call_exec_bad2(int length) {
|
||||
std::ifstream is("test.txt", std::ifstream::binary);
|
||||
if (is) {
|
||||
char* buffer = new char[length];
|
||||
is.readsome(buffer, length);
|
||||
execle(buffer, NULL);
|
||||
is.close();
|
||||
}
|
||||
}
|
||||
|
||||
void read_file_call_exec_bad3(int length) {
|
||||
std::ifstream is("test.txt", std::ifstream::binary);
|
||||
if (is) {
|
||||
char* buffer = new char[length];
|
||||
is.getline(buffer, length);
|
||||
execle(buffer, NULL);
|
||||
is.close();
|
||||
}
|
||||
}
|
||||
|
||||
// have to do matching on C procnames to make this work
|
||||
void FN_read_file_call_exec_bad5(int length) {
|
||||
std::ifstream is("test.txt", std::ifstream::binary);
|
||||
if (is) {
|
||||
char* buffer = new char[length];
|
||||
is >> buffer;
|
||||
execle(buffer, NULL);
|
||||
is.close();
|
||||
}
|
||||
}
|
||||
|
||||
// make sure we handle reads via iostreams too
|
||||
void read_file_call_exec_bad5(std::iostream is, int length) {
|
||||
if (is) {
|
||||
char* buffer = new char[length];
|
||||
is.getline(buffer, length);
|
||||
execle(buffer, NULL);
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Reference in new issue