[IR] kill unused `Sil.hpred` payload

Summary:
hmmhmmhmm

Also `Sil.hpred` is going to move out of IR/ in a few diffs, into
biabduction/ where it belongs.

Reviewed By: ngorogiannis

Differential Revision: D19158535

fbshipit-source-id: e2a889ee2

infer/src/IR/Exceptions.ml

@@ -86,9 +86,7 @@ exception Internal_error of Localise.error_desc
 
 exception Java_runtime_exception of Typ.Name.t * string * Localise.error_desc
 
-exception
+exception Leak of bool * (visibility * Localise.error_desc) * bool * PredSymb.resource * L.ocaml_pos
-  Leak of
-    bool * Sil.hpred * (visibility * Localise.error_desc) * bool * PredSymb.resource * L.ocaml_pos
 
 exception Missing_fld of Typ.Fieldname.t * L.ocaml_pos
 
@@ -378,7 +376,7 @@ let recognize_exception exn =
       ; visibility= Exn_user
       ; severity= None
       ; category= Prover }
-  | Leak (fp_part, _, (exn_vis, error_desc), done_array_abstraction, resource, ocaml_pos) ->
+  | Leak (fp_part, (exn_vis, error_desc), done_array_abstraction, resource, ocaml_pos) ->
       if done_array_abstraction then
         { name= IssueType.leak_after_array_abstraction
         ; description= error_desc

infer/src/IR/Exceptions.mli

@@ -88,13 +88,7 @@ exception Internal_error of Localise.error_desc
 exception Java_runtime_exception of Typ.Name.t * string * Localise.error_desc
 
 exception
-  Leak of
+  Leak of bool * (visibility * Localise.error_desc) * bool * PredSymb.resource * Logging.ocaml_pos
-    bool
-    * Sil.hpred
-    * (visibility * Localise.error_desc)
-    * bool
-    * PredSymb.resource
-    * Logging.ocaml_pos
 
 exception Missing_fld of Typ.Fieldname.t * Logging.ocaml_pos
 

infer/src/biabduction/Abs.ml

@@ -1074,7 +1074,6 @@ let check_junk pname tenv prop =
             let exn_leak =
               Exceptions.Leak
                 ( fp_part
-                , hpred
                 , Errdesc.explain_leak tenv hpred prop alloc_attribute ml_bucket_opt
                 , !Absarray.array_abstraction_performed
                 , resource