[pulse][objc] Enable nil issue types by default

Summary:
Facebook
Will censor issues in fbobjc

Reviewed By: jvillard

Differential Revision: D28287273

fbshipit-source-id: 7696b6540

infer/man/man1/infer-full.txt

@@ -541,8 +541,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),

infer/man/man1/infer-report.txt

@@ -218,8 +218,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),

infer/man/man1/infer.txt

@@ -541,8 +541,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),

infer/src/base/IssueType.ml

@@ -790,12 +790,12 @@ let mutable_local_variable_in_component_file =
 
 
 let nil_insertion_into_collection =
-  register ~enabled:false ~id:"NIL_INSERTION_INTO_COLLECTION" Error Pulse
+  register ~id:"NIL_INSERTION_INTO_COLLECTION" Error Pulse
     ~user_documentation:"Inserting nil into a collection is an error in Objective-C."
 
 
 let nil_messaging_to_non_pod =
-  register ~enabled:false ~id:"NIL_MESSAGING_TO_NON_POD" Error Pulse
+  register ~id:"NIL_MESSAGING_TO_NON_POD" Error Pulse
     ~user_documentation:
       "Calling a method that returns a C++ non-POD object on the nil object is undefined behavior \
        in Objective-C++."