Revert "[infer][java] add an option to disable the creation of the human readable list of issues found"

Summary:
This option is not needed anymore as it was introduced to counter an uncovered
perf issue with creating human readable reports. The perf issue has been
addressed.

Instead of this option, one can use `infer --report-hook /bin/true ...` to
disable reporting. However, right now the Buck integration doesn't honor it so
this would need to be fixed to be a true equivalent of `--disable-bug-list`.

Reviewed By: jberdine

Differential Revision: D4712877

fbshipit-source-id: a09304f

infer/lib/python/inferlib/analyze.py

@@ -38,10 +38,6 @@ base_group.add_argument('--debug-exceptions', action='store_true',
                         just print the internal exceptions during analysis''')
 base_group.add_argument('-g', '--debug', action='store_true',
                         help='Generate all debugging information')
-base_group.add_argument('--disable-bug-list', action='store_true',
-                        help='''Disable the creation of the human readable list
-                        of issues found. Useful for CI integration when only
-                        the JSON report is used''')
 base_group.add_argument('-a', '--analyzer',
                         help='Select the analyzer within: {0}'.format(
                             ', '.join(config.ANALYZERS)),

infer/lib/python/inferlib/bucklib.py

@@ -163,12 +163,11 @@ def collect_results(args, start_time, targets):
         report.write(json_string)
         report.flush()
 
-    if not args.disable_bug_list:
+    bugs_out = os.path.join(args.infer_out, config.BUGS_FILENAME)
-        bugs_out = os.path.join(args.infer_out, config.BUGS_FILENAME)
+    issues.print_and_save_errors(args.infer_out, args.project_root,
-        issues.print_and_save_errors(args.infer_out, args.project_root,
+                                 json_report, bugs_out, args.pmd_xml)
-                                     json_report, bugs_out, args.pmd_xml)
+    shutil.copy(bugs_out, os.path.join(args.infer_out,
-        shutil.copy(bugs_out, os.path.join(args.infer_out,
+                                       ANALYSIS_SUMMARY_OUTPUT))
-                                           ANALYSIS_SUMMARY_OUTPUT))
 
 
 def cleanup(temp_files):

infer/src/backend/infer.ml

@@ -242,8 +242,6 @@ let capture = function
              ["--debug"]) @
           (if not Config.debug_exceptions then [] else
              ["--debug-exceptions"]) @
-          (if not Config.disable_bug_list then [] else
-             ["--disable-bug-list"]) @
           (if Config.filtering then [] else
              ["--no-filtering"]) @
           (if not Config.flavors || not in_buck_mode then [] else

infer/src/base/Config.ml

@@ -827,12 +827,6 @@ and dependencies =
     "Translate all the dependencies during the capture. The classes in the given jar file will be \
      translated. No sources needed."
 
-and disable_bug_list =
-  CLOpt.mk_bool ~long:"disable-bug-list"
-    ~parse_mode:CLOpt.(Infer [Driver])
-    "Disable the creation of the human readable list of issues found. \
-     Useful for CI integration when only the JSON report is used"
-
 and disable_checks =
   CLOpt.mk_string_list ~deprecated:["disable_checks"] ~long:"disable-checks" ~meta:"error name"
     ~parse_mode:CLOpt.(Infer [Driver;Print])
@@ -1599,7 +1593,6 @@ and debug_mode = !debug
 and debug_exceptions = !debug_exceptions
 and dependency_mode = !dependencies
 and developer_mode = !developer_mode
-and disable_bug_list = !disable_bug_list
 and disable_checks = !disable_checks
 and dotty_cfg_libs = !dotty_cfg_libs
 and enable_checks = !enable_checks

infer/src/base/Config.mli

@@ -208,7 +208,6 @@ val debug_mode : bool
 val debug_exceptions : bool
 val dependency_mode : bool
 val developer_mode : bool
-val disable_bug_list : bool
 val disable_checks : string list
 val dotty_cfg_libs : bool
 val dynamic_dispatch : [ `None | `Interface | `Sound | `Lazy ]