Add `make -C infer/src test_build` to `make test`

Summary:
Non-fatal warnings are only checked by `make -C infer/src test_build`,
which should be part of `make test`

Reviewed By: sblackshear

Differential Revision: D3301913

fbshipit-source-id: 8196e03

Makefile.in

@@ -86,6 +86,9 @@ endif
 clang: clang_plugin
 endif
 
+test_build_src:
+	$(MAKE) -C $(SRC_DIR) test_build
+
 test_build_clang: clang_plugin
 	$(MAKE) -C $(INFER_DIR) clang
 
@@ -95,7 +98,7 @@ test_build_java:
 test_build_llvm:
 	$(MAKE) -C $(INFER_DIR) llvm
 
-test_build: test_build_clang test_build_java test_build_llvm
+test_build: test_build_src test_build_clang test_build_java test_build_llvm
 
 unit:
 	$(MAKE) -C $(SRC_DIR) unit

infer/src/backend/taint.ml

@@ -219,13 +219,6 @@ let objc_method_to_procname objc_method =
   Procname.ObjC_Cpp
     (Procname.objc_cpp objc_method.classname objc_method.method_name mangled)
 
-let method_str_to_pname method_str =
-  match method_str.language with
-  | Config.Clang ->
-      objc_method_to_procname method_str
-  | Config.Java ->
-      java_method_to_procname method_str
-
 let taint_spec_to_taint_info taint_spec =
   let taint_source =
     match taint_spec.language with

infer/src/clang/cMethod_trans.ml

@@ -291,7 +291,7 @@ let skip_property_accessor ms =
   let open Clang_ast_t in
   let pointer_to_property_opt = CMethod_signature.ms_get_pointer_to_property_opt ms in
   match Ast_utils.get_decl_opt pointer_to_property_opt with
-  | Some (ObjCPropertyDecl _ as d) -> true
+  | Some (ObjCPropertyDecl _) -> true
   | _ -> false
 
 let get_formal_parameters tenv ms =