[threadsafety] Skip indirect calls in C++

Summary:
They are expected to occur in C++ code, so don't fail on them. For now
just skip them, although a better treatment of dynamic dispatch may be
needed later.

Reviewed By: da319, mbouaziz

Differential Revision: D5292462

fbshipit-source-id: 4285514

infer/src/checkers/ThreadSafety.ml

@@ -810,7 +810,11 @@ module TransferFunctions (CFG : ProcCfg.S) = struct
               astate in
         { astate' with accesses; }
     | Call (_, Indirect _, _, _, _) ->
-        failwithf "Unexpected indirect call instruction %a" HilInstr.pp instr
+        match Procdesc.get_proc_name pdesc with
+        | Typ.Procname.Java _ ->
+            failwithf "Unexpected indirect call instruction %a" HilInstr.pp instr
+        | _ ->
+            astate
 end
 
 module Analyzer = AbstractInterpreter.Make (ProcCfg.Normal) (LowerHil.Make(TransferFunctions))

infer/src/checkers/ThreadSafetyDomain.ml

@@ -11,8 +11,6 @@ open! IStd
 
 module F = Format
 
-module AccessPathSetDomain = AbstractDomain.InvertedSet(AccessPath.RawSet)
-
 module Access = struct
   type kind =
     | Read

infer/src/checkers/ThreadSafetyDomain.mli

@@ -11,8 +11,6 @@ open! IStd
 
 module F = Format
 
-module AccessPathSetDomain : module type of AbstractDomain.InvertedSet (AccessPath.RawSet)
-
 module Access : sig
   type kind =
     | Read