[quandary] Inline internal analyze_call

Reviewed By: ngorogiannis

Differential Revision: D13487935

fbshipit-source-id: da748169b

infer/src/quandary/TaintAnalysis.ml

@@ -640,14 +640,11 @@ module Make (TaintSpecification : TaintSpec.S) = struct
         | _ ->
             Some ret_ap
       in
-      let analyze_call astate_acc callee_pname =
       let call_site = CallSite.make callee_pname callee_loc in
       let astate_with_sink =
         if List.is_empty actuals then astate
         else
-            let sinks =
+          let sinks = TraceDomain.Sink.get call_site actuals call_flags proc_data.ProcData.tenv in
-              TraceDomain.Sink.get call_site actuals call_flags proc_data.ProcData.tenv
-            in
           List.fold sinks ~init:astate ~f:(fun astate sink ->
               add_sink sink actuals astate proc_data call_site )
       in
@@ -695,9 +692,7 @@ module Make (TaintSpecification : TaintSpec.S) = struct
           | None ->
               astate_with_summary )
       in
-        Domain.join astate_acc astate_with_sanitizer
+      astate_with_sanitizer
-      in
-      analyze_call Domain.empty callee_pname
 
 
     let exec_instr (astate : Domain.t) (proc_data : extras ProcData.t) _ (instr : HilInstr.t) =