[infer][test] The command should change directory outside the call to silent_on_success

Summary: I also did some cleanup of the Makefile

Reviewed By: jberdine

Differential Revision: D4294239

fbshipit-source-id: 2d88257

infer/tests/build_systems/buck/Makefile

@@ -20,18 +20,11 @@ include $(TESTS_DIR)/java.make
 include $(TESTS_DIR)/base.make
 
 $(JAR_OUTPUT): $(JAVA_SOURCE_FILES)
-	$(call silent_on_success,\
+	cd $(ROOT_DIR) && $(call silent_on_success, INFER_BIN=$(INFER_BIN) NO_BUCKD=1 buck build --no-cache //infer/tests/codetoanalyze/java/infer:compile)
-	  cd $(ROOT_DIR) && \
-	  INFER_BIN=$(INFER_BIN) NO_BUCKD=1 buck build --no-cache //infer/tests/codetoanalyze/java/infer:compile)
 
 .PHONY: genrule
 genrule: $(JAR_OUTPUT)
-	$(call silent_on_success,\
+	cd $(ROOT_DIR) && $(call silent_on_success, INFER_BIN=$(INFER_BIN) NO_BUCKD=1 buck build --no-cache //infer/tests/codetoanalyze/java/infer:run_infer)
-	  cd $(ROOT_DIR) && \
-	  INFER_BIN=$(INFER_BIN) NO_BUCKD=1 buck build --no-cache //infer/tests/codetoanalyze/java/infer:run_infer)
 
 infer-out/report.json: genrule $(INFER_BIN) $(JAVA_SOURCE_FILES)
-	$(call silent_on_success,\
+	cd $(ROOT_DIR) && $(call silent_on_success, INFER_BIN=$(INFER_BIN) NO_BUCKD=1 $(INFER_BIN) -a $(ANALYZER) --results-dir $(CURDIR)/infer-out  -- buck build --no-cache //infer/tests/codetoanalyze/java/infer:compile)
-	  cd $(ROOT_DIR) && \
-	  INFER_BIN=$(INFER_BIN) NO_BUCKD=1 $(INFER_BIN) -a $(ANALYZER) --results-dir $(CURDIR)/infer-out  -- \
-	    buck build --no-cache //infer/tests/codetoanalyze/java/infer:compile)