[pulse] Remove empty edges and their WrittenTo from post

Summary: Like we removed empty edges from the `pre_heap` in D16419183, let's do the same to `post_heap`.

Reviewed By: skcho

Differential Revision: D17111336

fbshipit-source-id: c35fcbabb

infer/src/pulse/PulseAbductiveDomain.ml

@@ -296,14 +296,14 @@ module PrePost = struct
         (fun var _ -> Var.appears_in_source_code var && not (is_local var astate))
         (astate.post :> PulseDomain.t).stack
     in
-    (* deregister empty edges in pre *)
+    (* deregister empty edges *)
-    let pre_heap =
+    let deregister_empty heap =
-      BaseMemory.filter_heap
+      BaseMemory.filter_heap (fun _addr edges -> not (BaseMemory.Edges.is_empty edges)) heap
-        (fun _addr edges -> not (BaseMemory.Edges.is_empty edges))
-        (astate.pre :> base_domain).heap
     in
+    let pre_heap = deregister_empty (astate.pre :> base_domain).heap in
+    let post_heap = deregister_empty (astate.post :> base_domain).heap in
     { pre= InvertedDomain.update astate.pre ~heap:pre_heap
-    ; post= Domain.update ~stack:post_stack astate.post }
+    ; post= Domain.update ~stack:post_stack ~heap:post_heap astate.post }
 
 
   let add_out_of_scope_attribute addr pvar location history heap typ =