[threadsafety] Testing if a race that happened in a private method is reported in a caller public method.

Summary: See title.

Reviewed By: jberdine

Differential Revision: D5697916

fbshipit-source-id: cef9eaa

infer/tests/codetoanalyze/cpp/threadsafety/basics.cpp

@@ -44,11 +44,15 @@ class Basic {
 
   int get4() { return suspiciously_read; }
 
+  int get5() { return get_private_suspiciously_read(); }
+
  private:
   int well_guarded;
   int suspiciously_read;
   int suspiciously_written;
   int not_guarded;
   std::mutex mutex_;
+
+  int get_private_suspiciously_read() { return suspiciously_read; }
 };
 }

infer/tests/codetoanalyze/cpp/threadsafety/issues.exp

@@ -1,5 +1,6 @@
 codetoanalyze/cpp/threadsafety/basics.cpp, basics::Basic_get2, 3, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,access to `suspiciously_written`,<Beginning of write trace>,access to `suspiciously_written`]
 codetoanalyze/cpp/threadsafety/basics.cpp, basics::Basic_get4, 0, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,access to `suspiciously_read`,<Beginning of write trace>,access to `suspiciously_read`]
+codetoanalyze/cpp/threadsafety/basics.cpp, basics::Basic_get5, 0, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,call to basics::Basic_get_private_suspiciously_read,access to `suspiciously_read`,<Beginning of write trace>,access to `suspiciously_read`]
 codetoanalyze/cpp/threadsafety/lock_guard.cpp, basics::LockGuard_get2, 3, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,access to `suspiciously_written`,<Beginning of write trace>,access to `suspiciously_written`]
 codetoanalyze/cpp/threadsafety/lock_guard.cpp, basics::LockGuard_get4, 0, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,access to `suspiciously_read`,<Beginning of write trace>,access to `suspiciously_read`]
 codetoanalyze/cpp/threadsafety/lock_guard.cpp, basics::LockGuard_test1, 2, THREAD_SAFETY_VIOLATION, [<Beginning of read trace>,access to `suspiciously_read`,<Beginning of write trace>,access to `suspiciously_read`]