[reactive] always delete specs dir

Summary:
Specs do not get invalidated by reactive mode, so we need to delete them all.
Reactive just means that the capture remains valid and the analysis will only
use the freshly captured source files to start the analysis, but all the
dependencies will be re-analysed.

Reviewed By: da319

Differential Revision: D8735171

fbshipit-source-id: dc1eab3

infer/src/backend/InferAnalyze.ml

@@ -73,9 +73,7 @@ let main ~changed_files =
   | None ->
       () ) ;
   register_active_checkers () ;
-  (* delete all specs when doing a full analysis so that we do not report on procedures that do
-         not exist anymore *)
-  if not Config.reactive_mode then DB.Results_dir.clean_specs_dir () ;
+  DB.Results_dir.clean_specs_dir () ;
   let all_source_files = SourceFiles.get_all () in
   let source_files_to_analyze =
     List.filter ~f:(source_file_should_be_analyzed ~changed_files) all_source_files