pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[componentkit] Whitelist Native Templates

Browse Source 
Reviewed By: tks2103

Differential Revision: D4090237

fbshipit-source-id: 63f233e
master
Ryan Rhee 8 years ago committed by Facebook Github Bot
parent a45d59e478
commit aac14999b0
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File

3
infer/src/clang/ComponentKit.ml
Unescape View File

@ -156,7 +156,8 @@ let component_with_unconventional_superclass_advice context decl =
ckcomponentcontroller_cl; ckcomponentcontroller_cl;
"CKCompositeComponent"; "CKCompositeComponent";
"CKStatefulViewComponent"; "CKStatefulViewComponent";
"CKStatefulViewComponentController" "CKStatefulViewComponentController";
"NTNativeTemplateComponent"
] -> true ] -> true
| _ -> false in | _ -> false in
let condition = let condition =

6
infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
Unescape View File

@ -16,3 +16,9 @@
@interface BarComponent : FooComponent // bad @interface BarComponent : FooComponent // bad
@end @end
@interface NTNativeTemplateComponent : CKCompositeComponent // fake NT
@end
@interface NativeTemplateComponent : NTNativeTemplateComponent // good
@end

3
infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
Unescape View File

@ -16,3 +16,6 @@
@implementation BarComponent @implementation BarComponent
@end @end
@implementation NativeTemplateComponent
@end

Write Preview
Loading…
Cancel
Save