[componentkit] Whitelist Native Templates

Reviewed By: tks2103 Differential Revision: D4090237 fbshipit-source-id: 63f233e
8 years ago · aac14999b0
parent a45d59e478
commit aac14999b0
3 changed files with 11 additions and 1 deletions
--- a/infer/src/clang/ComponentKit.ml
+++ b/infer/src/clang/ComponentKit.ml
@ -156,7 +156,8 @@ let component_with_unconventional_superclass_advice context decl =
                ckcomponentcontroller_cl;
                "CKCompositeComponent";
                "CKStatefulViewComponent";
-                "CKStatefulViewComponentController"
+                "CKStatefulViewComponentController";
+                "NTNativeTemplateComponent"
              ] -> true
            | _ -> false in
          let condition =
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
@ -16,3 +16,9 @@

@interface BarComponent : FooComponent // bad
@end
+
+@interface NTNativeTemplateComponent : CKCompositeComponent // fake NT
+@end
+
+@interface NativeTemplateComponent : NTNativeTemplateComponent // good
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
@ -16,3 +16,6 @@

@implementation BarComponent
@end
+
+@implementation NativeTemplateComponent
+@end