[pulse][minor] remove skipped_calls getter

Summary:
Now that the shape of the record type of AbductiveDomain.t is known, we
don't need this getter anymore. Keep `get_pre` and `get_post` as they
perform useful casting to `BaseDomain.t`.

Reviewed By: ezgicicek

Differential Revision: D21022924

fbshipit-source-id: 340f4edf8

infer/src/checkers/impurity.ml

@@ -155,9 +155,9 @@ let extract_impurity tenv pdesc (exec_state : ExecutionDomain.t) : ImpurityDomai
   in
   let modified_globals = get_modified_globals pre_heap post post_stack in
   let skipped_calls =
-    AbductiveDomain.get_skipped_calls astate
-    |> SkippedCalls.filter (fun proc_name _ ->
-           Purity.should_report proc_name && not (is_modeled_pure tenv proc_name) )
+    SkippedCalls.filter
+      (fun proc_name _ -> Purity.should_report proc_name && not (is_modeled_pure tenv proc_name))
+      astate.AbductiveDomain.skipped_calls
   in
   {modified_globals; modified_params; skipped_calls; exited}
 

infer/src/pulse/PulseAbductiveDomain.ml

@@ -416,5 +416,3 @@ let of_post pdesc astate =
 let get_pre {pre} = (pre :> BaseDomain.t)
 
 let get_post {post} = (post :> BaseDomain.t)
-
-let get_skipped_calls {skipped_calls} = skipped_calls

infer/src/pulse/PulseAbductiveDomain.mli

@@ -67,8 +67,6 @@ val get_pre : t -> BaseDomain.t
 
 val get_post : t -> BaseDomain.t
 
-val get_skipped_calls : t -> SkippedCalls.t
-
 (** stack operations like {!BaseStack} but that also take care of propagating facts to the
     precondition *)
 module Stack : sig