pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[inferbo] Address collection add in loop

Browse Source 
Summary:
This diff addresses collection adds in loop.  For example,

```
ArrayList<...> a = new ArrayList<>();
for (int i = 0; i < size; i++) {
    a.add(...);
}
// we want to know the size of `a` here!
```

This is a common pattern on initializing a collection in Java.

How we did: Instead of adopting general (but complicated) solutions such as relational domain, we
extended the current alias domain of inferbo, to be able to handle this specific case:

* An array `a` should have size 0, at the entry of the loop.
* The iterating variable `i` should start with 0.
* `add` should be called once inside the loop.

Reviewed By: jvillard

Differential Revision: D17319350

fbshipit-source-id: 99b6acae1
master
Sungkeun Cho 5 years ago committed by Facebook Github Bot
parent 4f8629727e
commit afcb0ab46b
6 changed files with 160 additions and 49 deletions
Show Stats Download Patch File Download Diff File

140
infer/src/bufferoverrun/bufferOverrunDomain.ml
Unescape View File

@ -396,6 +396,8 @@ module Val = struct
{x with traces}
let array_sizeof {arrayblk} = ArrayBlk.sizeof arrayblk
let set_array_length : Location.t -> length:t -> t -> t =
fun location ~length v ->
{ v with
@ -705,27 +707,50 @@ module MemPure = struct
end
module AliasTarget = struct
(* Relations between values of logical variables(registers) and program variables
"Simple relation": Since Sil distinguishes logical and program variables, we need a relation for
pruning values of program variables. For example, a C statement "if(x){...}" is translated to
"%r=load(x); if(%r){...}" in Sil. At the load statement, we record the alias between the
values of %r and x, then we can prune not only the value of %r, but also that of x inside the
if branch.
"Empty relation": For pruning vector.length with vector::empty() results, we adopt a specific
relation between %r and v->elements, where %r=v.empty(). So, if %r!=0, v's array length
([v->elements->length]) is pruned by 0. On the other hand, if %r==0, v's array length is
pruned by >=1.
"Size relation": This is for pruning vector's length. When there is a function call,
%r=x.size(), the alias target for %r becomes AliasTarget.size {l=x.elements}. The java_tmp
field is an additional slot for keeping one more alias of temporary variable in Java. The i
field is to express "%r=x.size()+i", which is required to follow the semantics of `Array.add`
inside loops precisely. *)
type t =
| Simple of Loc.t
| SimplePlusA of Loc.t * IntLit.t
| Empty of Loc.t
| Size of {l: Loc.t; java_tmp: Loc.t option}
| Size of {l: Loc.t; i: IntLit.t; java_tmp: Loc.t option}
| Fgets of Loc.t
| Top
[@@deriving compare]
let equal = [%compare.equal: t]
let pp fmt = function
let pp =
let intlit_pp fmt i =
if IntLit.isnegative i then F.fprintf fmt "-%a" IntLit.pp (IntLit.neg i)
else F.fprintf fmt "+%a" IntLit.pp i
in
fun fmt -> function
| Simple l ->
Loc.pp fmt l
| SimplePlusA (l, i) ->
if IntLit.isnegative i then F.fprintf fmt "%a-%a" Loc.pp l IntLit.pp (IntLit.neg i)
else F.fprintf fmt "%a+%a" Loc.pp l IntLit.pp i
Loc.pp fmt l ; intlit_pp fmt i
| Empty l ->
F.fprintf fmt "empty(%a)" Loc.pp l
| Size {l; java_tmp} ->
| Size {l; i; java_tmp} ->
F.fprintf fmt "size(%a)" Loc.pp l ;
if not (IntLit.iszero i) then intlit_pp fmt i ;
Option.iter java_tmp ~f:(F.fprintf fmt "=%a" Loc.pp)
| Fgets l ->
F.fprintf fmt "fgets(%a)" Loc.pp l
@ -754,9 +779,9 @@ module AliasTarget = struct
Option.map (f l) ~f:(fun l -> SimplePlusA (l, i))
| Empty l ->
Option.map (f l) ~f:(fun l -> Empty l)
| Size {l; java_tmp} ->
| Size {l; i; java_tmp} ->
let java_tmp = Option.value_map java_tmp ~default:None ~f in
Option.map (f l) ~f:(fun l -> Size {l; java_tmp})
Option.map (f l) ~f:(fun l -> Size {l; i; java_tmp})
| Fgets l ->
Option.map (f l) ~f:(fun l -> Fgets l)
| Top ->
@ -770,35 +795,26 @@ module AliasTarget = struct
let widen ~prev ~next ~num_iters:_ = join prev next
let is_unknown x = PowLoc.exists Loc.is_unknown (get_locs x)
end
(* Relations between values of logical variables(registers) and program variables
"AliasTarget.Simple relation": Since Sil distinguishes logical and program variables, we need a
relation for pruning values of program variables. For example, a C statement "if(x){...}" is
translated to "%r=load(x); if(%r){...}" in Sil. At the load statement, we record the alias
between the values of %r and x, then we can prune not only the value of %r, but also that of x
inside the if branch.
"AliasTarget.Empty relation": For pruning vector.length with vector::empty() results, we adopt a
specific relation between %r and v->elements, where %r=v.empty(). So, if %r!=0, v's array length
([v->elements->length]) is pruned by 0. On the other hand, if %r==0, v's array length is pruned
by >=1.
let incr_size_alias loc x =
match x with
| Size {l; i} when Loc.equal l loc ->
Size {l; i= IntLit.(add i minus_one); java_tmp= None}
| _ ->
x
end
"AliasTarget.Size relation": This is for pruning vector's length. When there is a function call,
%r=x.size(), the alias target for %r becomes AliasTarget.size {l=x.elements}. The java_tmp field
is an additional slot for keeping one more alias of temporary variable in Java. *)
module AliasMap = struct
module Key = struct
type t = IdentKey of Ident.t | JavaTmp of Loc.t [@@deriving compare]
type t = IdentKey of Ident.t | LocKey of Loc.t [@@deriving compare]
let of_id id = IdentKey id
let of_java_tmp l = JavaTmp l
let of_loc l = LocKey l
let pp f = function IdentKey id -> Ident.pp f id | JavaTmp l -> Loc.pp f l
let pp f = function IdentKey id -> Ident.pp f id | LocKey l -> Loc.pp f l
let use_loc l = function JavaTmp l' -> Loc.equal l l' | IdentKey _ -> false
let use_loc l = function LocKey l' -> Loc.equal l l' | IdentKey _ -> false
end
include AbstractDomain.InvertedMap (Key) (AliasTarget)
@ -832,11 +848,11 @@ module AliasMap = struct
let find_id : Ident.t -> t -> AliasTarget.t option = fun id x -> find_opt (Key.of_id id) x
let find_java_tmp : Loc.t -> t -> AliasTarget.t option =
let find_loc : Loc.t -> t -> AliasTarget.t option =
fun loc x ->
match find_opt (Key.of_java_tmp loc) x with
| Some (AliasTarget.Size {l}) ->
Some (AliasTarget.Size {l; java_tmp= Some loc})
match find_opt (Key.LocKey loc) x with
| Some (AliasTarget.Size a) ->
Some (AliasTarget.Size {a with java_tmp= Some loc})
| _ as alias ->
alias
@ -848,7 +864,7 @@ module AliasMap = struct
let tgt =
match tgt with
| AliasTarget.Simple loc when Language.curr_language_is Java ->
Option.value (find_java_tmp loc x) ~default:tgt
Option.value (find_loc loc x) ~default:tgt
| _ ->
tgt
in
@ -862,8 +878,22 @@ module AliasMap = struct
let store : Loc.t -> Ident.t -> t -> t =
fun l id x ->
if Language.curr_language_is Java && Loc.is_frontend_tmp l then
Option.value_map (find_id id x) ~default:x ~f:(fun tgt -> add (Key.of_java_tmp l) tgt x)
Option.value_map (find_id id x) ~default:x ~f:(fun tgt -> add (Key.of_loc l) tgt x)
else x
let add_zero_size_alias ~size ~arr x =
add (Key.of_loc size) (AliasTarget.Size {l= arr; i= IntLit.zero; java_tmp= None}) x
let incr_size_alias loc = map (AliasTarget.incr_size_alias loc)
let store_n ~prev loc id n x =
match find_id id prev with
| Some (AliasTarget.Size {l; i}) ->
add (Key.of_loc loc) (AliasTarget.Size {l; i= IntLit.add i n; java_tmp= None}) x
| _ ->
x
end
module AliasRet = struct
@ -910,8 +940,8 @@ module Alias = struct
let load : Ident.t -> AliasTarget.t -> t -> t = fun id loc -> lift_map (AliasMap.load id loc)
let store_simple : Loc.t -> Exp.t -> t -> t =
fun loc e a ->
let a = lift_map (AliasMap.forget loc) a in
fun loc e prev ->
let a = lift_map (AliasMap.forget loc) prev in
match e with
| Exp.Var l ->
let a = lift_map (AliasMap.store loc l) a in
@ -922,8 +952,10 @@ module Alias = struct
| Exp.BinOp (Binop.PlusA _, Exp.Var id, Exp.Const (Const.Cint i))
| Exp.BinOp (Binop.PlusA _, Exp.Const (Const.Cint i), Exp.Var id) ->
lift_map (AliasMap.load id (AliasTarget.SimplePlusA (loc, IntLit.neg i))) a
|> lift_map (AliasMap.store_n ~prev:prev.map loc id i)
| Exp.BinOp (Binop.MinusA _, Exp.Var id, Exp.Const (Const.Cint i)) ->
lift_map (AliasMap.load id (AliasTarget.SimplePlusA (loc, i))) a
|> lift_map (AliasMap.store_n ~prev:prev.map loc id (IntLit.neg i))
| _ ->
a
@ -938,6 +970,25 @@ module Alias = struct
a
let incr_size_alias : PowLoc.t -> t -> t =
let incr_size_alias1 loc a = lift_map (AliasMap.incr_size_alias loc) a in
fun locs a -> PowLoc.fold incr_size_alias1 locs a
let add_empty_size_alias : Loc.t -> PowLoc.t -> t -> t =
fun loc arr_locs a ->
match PowLoc.is_singleton_or_more arr_locs with
| IContainer.Singleton arr_loc ->
lift_map (AliasMap.add_zero_size_alias ~size:loc ~arr:arr_loc) a
| More ->
(* NOTE: Keeping only one alias here is suboptimal, but current alias domain can keep one
alias for each ident, which will be extended later. *)
let arr_loc = PowLoc.min_elt arr_locs in
lift_map (AliasMap.add_zero_size_alias ~size:loc ~arr:arr_loc) a
| Empty ->
a
let remove_temp : Ident.t -> t -> t =
fun temp -> lift_map (AliasMap.remove (AliasMap.Key.of_id temp))
end
@ -1453,13 +1504,26 @@ module MemReach = struct
let store_simple_alias : Loc.t -> Exp.t -> t -> t =
fun loc e m -> {m with alias= Alias.store_simple loc e m.alias}
fun loc e m ->
match e with
| Exp.Const (Const.Cint zero) when IntLit.iszero zero ->
let arr_locs =
let add_arr l v acc =
if Itv.is_zero (Val.array_sizeof v) then PowLoc.add l acc else acc
in
MemPure.fold add_arr m.mem_pure PowLoc.empty
in
{m with alias= Alias.add_empty_size_alias loc arr_locs m.alias}
| _ ->
{m with alias= Alias.store_simple loc e m.alias}
let fgets_alias : Ident.t -> PowLoc.t -> t -> t =
fun id locs m -> {m with alias= Alias.fgets id locs m.alias}
let incr_size_alias locs m = {m with alias= Alias.incr_size_alias locs m.alias}
let add_stack_loc : Loc.t -> t -> t = fun k m -> {m with stack_locs= StackLocs.add k m.stack_locs}
let add_stack : ?represents_multiple_values:bool -> Loc.t -> Val.t -> t -> t =
@ -1772,7 +1836,7 @@ module Mem = struct
let load_size_alias : Ident.t -> Loc.t -> t -> t =
fun id loc -> load_alias id (AliasTarget.Size {l= loc; java_tmp= None})
fun id loc -> load_alias id (AliasTarget.Size {l= loc; i= IntLit.zero; java_tmp= None})
let store_simple_alias : Loc.t -> Exp.t -> t -> t =
@ -1783,6 +1847,8 @@ module Mem = struct
fun id locs -> map ~f:(MemReach.fgets_alias id locs)
let incr_size_alias locs = map ~f:(MemReach.incr_size_alias locs)
let add_stack_loc : Loc.t -> t -> t = fun k -> map ~f:(MemReach.add_stack_loc k)
let add_stack : ?represents_multiple_values:bool -> Loc.t -> Val.t -> t -> t =

9
infer/src/bufferoverrun/bufferOverrunModels.ml
Unescape View File

@ -855,7 +855,14 @@ module Collection = struct
mem
let add coll_id = {exec= change_size_by ~size_f:Itv.incr coll_id; check= no_check}
let add coll_id =
let exec {location} ~ret:_ mem =
let arr_locs = get_collection_internal_array_locs coll_id mem in
Dom.Mem.transform_mem ~f:(Dom.Val.transform_array_length location ~f:Itv.incr) arr_locs mem
|> Dom.Mem.incr_size_alias arr_locs
in
{exec; check= no_check}
let singleton_collection =
let exec env ~ret:((id, _) as ret) mem =

2
infer/src/bufferoverrun/itv.ml
Unescape View File

@ -600,6 +600,8 @@ let get_iterator_itv : t -> t = lift1 ItvPure.get_iterator_itv
let is_const : t -> Z.t option = bind1zo ItvPure.is_const
let is_zero = bind1bool ItvPure.is_zero
let is_one = bind1bool ItvPure.is_one
let is_mone = bind1bool ItvPure.is_mone

2
infer/src/bufferoverrun/itv.mli
Unescape View File

@ -147,6 +147,8 @@ val of_int_lit : IntLit.t -> t
val is_const : t -> Z.t option
val is_zero : t -> bool
val is_one : t -> bool
val is_mone : t -> bool

32
infer/tests/codetoanalyze/java/bufferoverrun/ArrayListTest.java
Unescape View File

@ -17,4 +17,36 @@ class ArrayListTest {
// initial capacity cannot be negative
ArrayList<Integer> x = new ArrayList<Integer>(9);
}
void add_in_loop_ok() {
ArrayList<Integer> a = new ArrayList<>();
for (int i = 0; i < 5; i++) {
a.add(0);
}
int j = a.get(3);
}
void add_in_loop_bad() {
ArrayList<Integer> a = new ArrayList<>();
for (int i = 0; i < 5; i++) {
a.add(0);
}
int j = a.get(6);
}
void add_in_loop_by_param_ok(ArrayList<Integer> b) {
ArrayList<Integer> a = new ArrayList<>();
for (int i = 0; i < b.size(); i++) {
a.add(0);
}
int j = a.get(b.size() - 1);
}
void add_in_loop_by_param_bad(ArrayList<Integer> b) {
ArrayList<Integer> a = new ArrayList<>();
for (int i = 0; i < b.size(); i++) {
a.add(0);
}
int j = a.get(b.size() + 1);
}
}

2
infer/tests/codetoanalyze/java/bufferoverrun/issues.exp
Unescape View File

@ -6,6 +6,8 @@ codetoanalyze/java/bufferoverrun/Array.java, codetoanalyze.java.bufferoverrun.Ar
codetoanalyze/java/bufferoverrun/Array.java, codetoanalyze.java.bufferoverrun.Array.null_pruning1_Good():void, 2, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/java/bufferoverrun/Array.java, codetoanalyze.java.bufferoverrun.Array.null_pruning2_Bad():void, 4, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset: 10 Size: 5]
codetoanalyze/java/bufferoverrun/Array.java, codetoanalyze.java.bufferoverrun.Array.null_pruning2_Good_FP():void, 4, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset: 10 Size: 5]
codetoanalyze/java/bufferoverrun/ArrayListTest.java, ArrayListTest.add_in_loop_bad():void, 5, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset: 6 Size: 5]
codetoanalyze/java/bufferoverrun/ArrayListTest.java, ArrayListTest.add_in_loop_by_param_bad(java.util.ArrayList):void, 5, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Offset trace>,Assignment,Array declaration,Assignment,<Length trace>,Parameter `b.elements[*]`,Assignment,Array declaration,Array access: Offset: b.length + 1 Size: b.length]
codetoanalyze/java/bufferoverrun/ArrayListTest.java, ArrayListTest.alloc_is_negative_bad():void, 2, INFERBO_ALLOC_IS_NEGATIVE, no_bucket, ERROR, [Allocation: Length: -1]
codetoanalyze/java/bufferoverrun/ArrayMember.java, codetoanalyze.java.bufferoverrun.ArrayMember.load_array_member_Bad():void, 4, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Offset trace>,Parameter `this.buf[*]`,Assignment,<Length trace>,Array declaration,Array access: Offset: [max(10, this.buf[*].lb), min(10, this.buf[*].ub)] Size: 10]
codetoanalyze/java/bufferoverrun/CompressedData.java, codetoanalyze.java.bufferoverrun.CompressedData.decompressData(codetoanalyze.java.bufferoverrun.CompressedData$D):int, 9, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `this.yy`,<RHS trace>,Parameter `d.cci[*].s`,Assignment,Binary operation: ([0, this.yy - 1] × d.cci[*].s):signed32]

Write Preview
Loading…
Cancel
Save