[CK][Linter Rule] Added CKRenderWithChildrenComponent as conventional component kit superclass

Reviewed By: mbouaziz Differential Revision: D13432225 fbshipit-source-id: 57b933cce
6 years ago · afed12ad52
parent 5a531ac755
commit afed12ad52
3 changed files with 14 additions and 0 deletions
--- a/infer/src/clang/ComponentKit.ml
+++ b/infer/src/clang/ComponentKit.ml
@ -226,6 +226,8 @@ let component_with_unconventional_superclass_advice context an =
                     [ ckcomponent_cl
                     ; ckcomponentcontroller_cl
                     ; "CKCompositeComponent"
+                     ; "CKRenderComponent"
+                     ; "CKRenderWithChildrenComponent"
                     ; "CKStatefulViewComponent"
                     ; "CKStatefulViewComponentController"
                     ; "NTNativeTemplateComponent" ]
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
@ -20,3 +20,9 @@

@interface NativeTemplateComponent : NTNativeTemplateComponent // good
@end
+
+@interface RenderFooComponent : CKRenderComponent // good
+@end
+
+@interface RenderWithChildrenFooComponent : CKRenderWithChildrenComponent // good
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
@ -17,3 +17,9 @@

@implementation NativeTemplateComponent
@end
+
+@implementation RenderFooComponent
+@end
+
+@implementation RenderWithChildrenFooComponent
+@end