[thread-safety][c++] Skip destructors

Summary:
The concurrency analyzer often does not understand object lifetimes
well enough to realize that destructors are usually not called in
parallel with any other methods. This leads to false alarms. This diff
suppresses these by simply skipping destructors in the concurrency
analysis.

Reviewed By: sblackshear

Differential Revision: D6182646

fbshipit-source-id: e9d1cac

infer/src/concurrency/RacerD.ml

@@ -558,7 +558,8 @@ module TransferFunctions (CFG : ProcCfg.S) = struct
            ["folly::AtomicStruct::load"; "folly::detail::SingletonHolder::createInstance"])
     in
     fun pname ->
-      QualifiedCppName.Match.match_qualifiers (Lazy.force matcher)
+      Typ.Procname.is_destructor pname
+      || QualifiedCppName.Match.match_qualifiers (Lazy.force matcher)
            (Typ.Procname.get_qualifiers pname)