remove --no-cache option, which does nothing

Reviewed By: jeremydubreil

Differential Revision: D2935683

fb-gh-sync-id: f81aec8
shipit-source-id: f81aec8
master
Sam Blackshear 9 years ago committed by facebook-github-bot-5
parent 07822ff16e
commit bb793770b9

@ -117,7 +117,7 @@ def prepare_build(args):
return temp_files, infer_script.name return temp_files, infer_script.name
def get_normalized_targets(targets, verbose): def get_normalized_targets(targets):
""" Use buck to convert a list of input targets/aliases """ Use buck to convert a list of input targets/aliases
into a set of the (transitive) target deps for all inputs""" into a set of the (transitive) target deps for all inputs"""
@ -132,10 +132,6 @@ def get_normalized_targets(targets, verbose):
targets = filter( targets = filter(
lambda line: len(line) > 0, lambda line: len(line) > 0,
subprocess.check_output(buck_cmd).decode().strip().split('\n')) subprocess.check_output(buck_cmd).decode().strip().split('\n'))
if len(targets) > 0 and verbose:
logging.debug('Targets to analyze:')
for target in targets:
logging.debug(target)
return targets return targets
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
logging.error('Error while expanding targets with {0}'.format(buck_cmd)) logging.error('Error while expanding targets with {0}'.format(buck_cmd))
@ -460,8 +456,7 @@ class Wrapper:
self.timer.start('Computing library targets') self.timer.start('Computing library targets')
base_cmd, buck_args = parse_buck_command(buck_cmd) base_cmd, buck_args = parse_buck_command(buck_cmd)
self.normalized_targets = get_normalized_targets( self.normalized_targets = get_normalized_targets(
buck_args.targets, buck_args.targets)
self.infer_args.verbose)
self.buck_cmd = base_cmd + self.normalized_targets self.buck_cmd = base_cmd + self.normalized_targets
self.timer.stop('%d targets computed', len(self.normalized_targets)) self.timer.stop('%d targets computed', len(self.normalized_targets))

@ -39,10 +39,6 @@ def create_argparser(group_name=MODULE_NAME):
"{grp} module".format(grp=MODULE_NAME), "{grp} module".format(grp=MODULE_NAME),
description=MODULE_DESCRIPTION, description=MODULE_DESCRIPTION,
) )
group.add_argument('--verbose', action='store_true',
help='Print buck compilation steps')
group.add_argument('--no-cache', action='store_true',
help='Do not use buck distributed cache')
group.add_argument('--print-harness', action='store_true', group.add_argument('--print-harness', action='store_true',
help='Print generated harness code (Android only)') help='Print generated harness code (Android only)')
group.add_argument('--use-flavors', action='store_true', group.add_argument('--use-flavors', action='store_true',
@ -152,6 +148,6 @@ class BuckAnalyzer:
return os.EX_OK return os.EX_OK
def capture_without_flavors(self): def capture_without_flavors(self):
# BuckAnalyze is a special case, and we run the analysis from here # Java is a special case, and we run the analysis from here
buck_wrapper = bucklib.Wrapper(self.args, self.cmd) buck_wrapper = bucklib.Wrapper(self.args, self.cmd)
return buck_wrapper.run() return buck_wrapper.run()

Loading…
Cancel
Save