[clang] Disable the condition always true or false check for clang as it is too noisy.

Reviewed By: jvillard

Differential Revision: D3967565

fbshipit-source-id: b81ea0c

infer/src/backend/symExec.ml

@@ -1039,6 +1039,8 @@ let rec sym_exec tenv current_pdesc _instr (prop_: Prop.normal Prop.t) path
   | Sil.Prune (cond, loc, true_branch, ik) ->
       let prop__ = Attribute.nullify_exp_with_objc_null tenv prop_ cond in
       let check_condition_always_true_false () =
+        if !Config.curr_language <> Config.Clang ||
+           Config.report_condition_always_true_in_clang then
           let report_condition_always_true_false i =
             let skip_loop = match ik with
               | Sil.Ik_while | Sil.Ik_for ->

infer/src/base/Config.ml

@@ -107,6 +107,8 @@ let checks_disabled_by_default = [
 
 let clang_build_output_dir_name = "build_output"
 
+let report_condition_always_true_in_clang = false
+
 (** Experimental: if true do some specialized analysis of concurrent constructs. *)
 let csl_analysis = true
 

infer/src/base/Config.mli

@@ -68,6 +68,7 @@ val buck_generated_folder : string
 val buck_infer_deps_file_name : string
 val captured_dir_name : string
 val checks_disabled_by_default : string list
+val report_condition_always_true_in_clang : bool
 val clang_build_output_dir_name : string
 val cpp_models_dir : string
 val csl_analysis : bool