Summary: Create model of C++ std::vector to find occurrences when vector which might be empty is accessed. Do it by triggering null dereference every time empty vector access is performed. Note: model will be used only when c++11 (or c++14) are used. Reviewed By: sblackshear Differential Revision: D3276203 fbshipit-source-id: 420a95amaster
Andrzej Kotulski
9 years ago
committed by
Facebook Github Bot 0
parent
6c7c18e920
commit
bfce6bac47
@ -0,0 +1,110 @@
|
||||
/*
|
||||
* Copyright (c) 2016 - present Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
#include <vector>
|
||||
|
||||
int access_empty() {
|
||||
const std::vector<int> vec;
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int access_nonempty() {
|
||||
const std::vector<int> vec(1);
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int clear_empty() {
|
||||
std::vector<int> vec(1);
|
||||
vec.clear();
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int resize0_empty() {
|
||||
std::vector<int> vec(1);
|
||||
vec.resize(0);
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int resize1_nonempty() {
|
||||
std::vector<int> vec;
|
||||
vec.resize(1);
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int push_back_nonempty() {
|
||||
std::vector<int> vec;
|
||||
vec.push_back(1);
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int copy_empty() {
|
||||
std::vector<int> vec1;
|
||||
std::vector<int> vec2 = vec1;
|
||||
return vec2[0];
|
||||
}
|
||||
|
||||
int copy_nonempty() {
|
||||
std::vector<int> vec1(10);
|
||||
std::vector<int> vec2 = vec1;
|
||||
return vec2[0];
|
||||
}
|
||||
|
||||
int assign_empty() {
|
||||
std::vector<int> vec1;
|
||||
std::vector<int> vec2(1);
|
||||
vec2 = vec1;
|
||||
return vec2[0];
|
||||
}
|
||||
|
||||
int assign_nonempty() {
|
||||
std::vector<int> vec1(1);
|
||||
std::vector<int> vec2;
|
||||
vec2 = vec1;
|
||||
return vec2[0];
|
||||
}
|
||||
|
||||
int empty_check_nonempty() {
|
||||
std::vector<int> vec;
|
||||
if (vec.empty()) {
|
||||
return 1;
|
||||
}
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int empty_check_nonempty2() {
|
||||
std::vector<int> vec;
|
||||
if (vec.empty()) {
|
||||
vec.push_back(1);
|
||||
}
|
||||
return vec[0];
|
||||
}
|
||||
|
||||
int empty_check_access_empty() {
|
||||
std::vector<int> vec;
|
||||
if (vec.empty()) {
|
||||
return vec[0];
|
||||
}
|
||||
return 1;
|
||||
}
|
||||
|
||||
int size_check0_empty() {
|
||||
std::vector<int> vec;
|
||||
if (vec.size() == 0) {
|
||||
return vec[0];
|
||||
}
|
||||
return 1;
|
||||
}
|
||||
|
||||
int size_check1_nonempty() {
|
||||
std::vector<int> vec;
|
||||
if (vec.size() > 0) {
|
||||
return vec[0];
|
||||
}
|
||||
return 1;
|
||||
}
|
||||
@ -0,0 +1,70 @@
|
||||
/*
|
||||
* Copyright (c) 2016 - present Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
package endtoend.cpp;
|
||||
|
||||
import static org.hamcrest.MatcherAssert.assertThat;
|
||||
import static utils.matchers.ResultContainsExactly.containsExactly;
|
||||
|
||||
|
||||
import com.google.common.collect.ImmutableList;
|
||||
|
||||
import org.junit.BeforeClass;
|
||||
import org.junit.ClassRule;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.io.IOException;
|
||||
|
||||
import utils.DebuggableTemporaryFolder;
|
||||
import utils.InferException;
|
||||
import utils.InferResults;
|
||||
import utils.InferRunner;
|
||||
|
||||
public class VectorEmptyAccessTest {
|
||||
|
||||
public static final String FILE =
|
||||
"infer/tests/codetoanalyze/cpp/errors/vector/empty_access.cpp";
|
||||
|
||||
private static ImmutableList<String> inferCmd;
|
||||
|
||||
public static final String NULL_DEREFERENCE = "NULL_DEREFERENCE";
|
||||
|
||||
@ClassRule
|
||||
public static DebuggableTemporaryFolder folder =
|
||||
new DebuggableTemporaryFolder();
|
||||
|
||||
@BeforeClass
|
||||
public static void runInfer() throws InterruptedException, IOException {
|
||||
inferCmd = InferRunner.createCPPInferCommand(folder, FILE);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void whenInferRunsNullDerefFunctionsErrorIsFound()
|
||||
throws InterruptedException, IOException, InferException {
|
||||
String[] procedures = {
|
||||
"access_empty",
|
||||
"clear_empty",
|
||||
"resize0_empty",
|
||||
"copy_empty",
|
||||
"assign_empty",
|
||||
"empty_check_access_empty",
|
||||
"size_check0_empty",
|
||||
};
|
||||
InferResults inferResults = InferRunner.runInferCPP(inferCmd);
|
||||
assertThat(
|
||||
"Results should contain empty vector access",
|
||||
inferResults,
|
||||
containsExactly(
|
||||
NULL_DEREFERENCE,
|
||||
FILE,
|
||||
procedures
|
||||
)
|
||||
);
|
||||
}
|
||||
}
|
||||
Loading…
Reference in new issue