[starvation][whole-program] gate analysis of constructors

Summary: In whole-program mode, analysing a method requires analysing first all constructors of the same class.  This is not needed in normal mode, so gate that computation under `starvation_whole_program` for efficiency.

Reviewed By: artempyanykh

Differential Revision: D19393412

fbshipit-source-id: 2277e6b5e

infer/src/concurrency/starvation.ml

@@ -329,12 +329,14 @@ let set_constructor_attributes tenv procname (astate : Domain.t) =
 
 
 let set_initial_attributes tenv procname astate =
+  if not Config.starvation_whole_program then astate
+  else
     match procname with
     | Procname.Java java_pname when Procname.Java.is_class_initializer java_pname ->
         (* we are analyzing the class initializer, don't go through on-demand again *)
         astate
-  | Procname.Java java_pname when Procname.Java.(is_constructor java_pname || is_static java_pname)
+    | Procname.Java java_pname
-    ->
+      when Procname.Java.(is_constructor java_pname || is_static java_pname) ->
         (* analyzing a constructor or static method, so we need the attributes established by the
            class initializer *)
         set_class_init_attributes procname astate