[thread-safety] use jsr-305 versions of ThreadSafe/NotThreadSafe rather than defining custom annotations

Summary: Just cleanup; gives us slightly less test code to maintain.

Reviewed By: jeremydubreil

Differential Revision: D4429265

fbshipit-source-id: d43c308

infer/tests/codetoanalyze/java/threadsafety/Annotations.java

@@ -14,6 +14,8 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import javax.annotation.concurrent.ThreadSafe;
+
 import android.support.annotation.UiThread;
 
 import com.facebook.infer.annotation.ThreadConfined;

infer/tests/codetoanalyze/java/threadsafety/Builders.java

@@ -9,6 +9,8 @@
 
 package codetoanalyze.java.checkers;
 
+import javax.annotation.concurrent.ThreadSafe;
+
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.MyImmutableList;
 import com.google.common.collect.ImmutableList.Builder;

infer/tests/codetoanalyze/java/threadsafety/Containers.java

@@ -9,6 +9,8 @@
 
 package codetoanalyze.java.checkers;
 
+import javax.annotation.concurrent.ThreadSafe;
+
 import java.util.HashMap;
 import java.util.Map;
 import java.util.concurrent.ConcurrentMap;

infer/tests/codetoanalyze/java/threadsafety/Locks.java

@@ -9,6 +9,8 @@
 
 package codetoanalyze.java.checkers;
 
+import javax.annotation.concurrent.ThreadSafe;
+
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantLock;

infer/tests/codetoanalyze/java/threadsafety/NotThreadSafeExample.java

@@ -9,17 +9,7 @@
 
 package codetoanalyze.java.checkers;
 
-import java.lang.annotation.Documented;
+import javax.annotation.concurrent.NotThreadSafe;
-import java.lang.annotation.ElementType;
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-import java.lang.annotation.Target;
-
-@Documented
-@Target(ElementType.TYPE)
-@Retention(RetentionPolicy.CLASS)
-@interface NotThreadSafe {
-}
 
 @NotThreadSafe
 public class NotThreadSafeExample{

infer/tests/codetoanalyze/java/threadsafety/Ownership.java

@@ -9,6 +9,8 @@
 
 package codetoanalyze.java.checkers;
 
+import javax.annotation.concurrent.ThreadSafe;
+
 class Obj {
   Object f;
   Obj g;

infer/tests/codetoanalyze/java/threadsafety/ThreadSafe.java

@@ -1,22 +0,0 @@
-/*
- * Copyright (c) 2016 - present Facebook, Inc.
- * All rights reserved.
- *
- * This source code is licensed under the BSD style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
- */
-
-package codetoanalyze.java.checkers;
-
-import java.lang.annotation.Documented;
-import java.lang.annotation.ElementType;
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-import java.lang.annotation.Target;
-
-@Documented
-@Target(ElementType.TYPE)
-@Retention(RetentionPolicy.CLASS)
-public @interface ThreadSafe {
-}

infer/tests/codetoanalyze/java/threadsafety/ThreadSafeExample.java

@@ -9,6 +9,9 @@
 
 package codetoanalyze.java.checkers;
 
+import javax.annotation.concurrent.NotThreadSafe;
+import javax.annotation.concurrent.ThreadSafe;
+
 import com.facebook.infer.annotation.ThreadSafeMethod;
 
 @ThreadSafe