[config] starvation on by default

Summary: Starvation is all grown up now!

Reviewed By: jeremydubreil

Differential Revision: D15158597

fbshipit-source-id: 8f5a2c3e2

infer/man/man1/infer-analyze.txt

@@ -99,7 +99,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --linters, --liveness, --ownership,
-           --racerd, --siof, --uninit (Conversely: --default-checkers)
+           --racerd, --siof, --starvation, --uninit (Conversely:
+           --default-checkers)
 
        --eradicate
            Activates: the eradicate @Nullable checker for Java annotations
@@ -301,8 +302,8 @@ OPTIONS
            Timeout for SQLite results database operations, in milliseconds.
            (default: five seconds times number of cores)
 
-       --starvation
-           Activates: starvation analysis (Conversely: --no-starvation)
+       --no-starvation
+           Deactivates: starvation analysis (Conversely: --starvation)
 
        --starvation-only
            Activates: Enable --starvation and disable all other checkers

infer/man/man1/infer-full.txt

@@ -279,8 +279,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --linters, --liveness, --ownership,
-           --racerd, --siof, --uninit (Conversely: --default-checkers)       
-    See also infer-analyze(1).
+           --racerd, --siof, --starvation, --uninit (Conversely:
+           --default-checkers)           See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -1039,8 +1039,8 @@ OPTIONS
            Timeout for SQLite results database operations, in milliseconds.
            (default: five seconds times number of cores)           See also infer-analyze(1), infer-capture(1), and infer-run(1).
 
-       --starvation
-           Activates: starvation analysis (Conversely: --no-starvation)       
+       --no-starvation
+           Deactivates: starvation analysis (Conversely: --starvation)       
     See also infer-analyze(1).
 
        --starvation-only

infer/man/man1/infer.txt

@@ -279,8 +279,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --biabduction,
            --fragment-retains-view, --linters, --liveness, --ownership,
-           --racerd, --siof, --uninit (Conversely: --default-checkers)       
-    See also infer-analyze(1).
+           --racerd, --siof, --starvation, --uninit (Conversely:
+           --default-checkers)           See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -1039,8 +1039,8 @@ OPTIONS
            Timeout for SQLite results database operations, in milliseconds.
            (default: five seconds times number of cores)           See also infer-analyze(1), infer-capture(1), and infer-run(1).
 
-       --starvation
-           Activates: starvation analysis (Conversely: --no-starvation)       
+       --no-starvation
+           Deactivates: starvation analysis (Conversely: --starvation)       
     See also infer-analyze(1).
 
        --starvation-only

infer/src/base/Config.ml

@@ -685,7 +685,7 @@ and ( annotation_reachability
   and siof =
     mk_checker ~long:"siof" ~default:true
       "the Static Initialization Order Fiasco analysis (C++ only)"
-  and starvation = mk_checker ~long:"starvation" ~default:false "starvation analysis"
+  and starvation = mk_checker ~long:"starvation" ~default:true "starvation analysis"
   and uninit = mk_checker ~long:"uninit" "checker for use of uninitialized values" ~default:true in
   let mk_only (var, long, doc, _) =
     let (_ : bool ref) =