[pules] do not print templated part of function names

Summary:
This messes with the deduplication heuristic when templated function
names show up in the error messages, since the heuristic demands that
the error messages are the same.

Reviewed By: mbouaziz

Differential Revision: D15374333

fbshipit-source-id: 70232d254

infer/src/IR/Typ.ml

@@ -1277,7 +1277,14 @@ module Procname = struct
   (** Pretty print a proc name *)
   let pp f pn = F.pp_print_string f (to_string pn)
 
-  let describe f pn = F.pp_print_string f (hashable_name pn)
+  let describe f pn =
+    let name = hashable_name pn in
+    match String.lsplit2 ~on:'<' name with
+    | Some (name_without_template, _template_part) ->
+        F.pp_print_string f name_without_template
+    | None ->
+        F.pp_print_string f name
+
 
   module Hashable = struct
     type nonrec t = t

infer/tests/codetoanalyze/cpp/pulse/deduplication.cpp

@@ -33,7 +33,7 @@ void SomeTemplatedClass<T>::lifetime_error_bad(A* a) {
   SomeTemplatedClass<T>::templated_wrapper_access_ok(a);
 }
 
-void materialize_template_instances() {
+void materialize_class_template_instances() {
   A* a1 = new A();
   SomeTemplatedClass<int> x1;
   x1.lifetime_error_bad(a1);
@@ -43,4 +43,33 @@ void materialize_template_instances() {
   x2.lifetime_error_bad(a2);
 }
 
+template <typename T>
+void templated_delete_function(T t, A* a) {
+  delete a;
+}
+
+template <typename T>
+void templated_access_function(T t, A* a) {
+  int x = a->f;
+}
+
+template <typename T>
+void templated_function_bad(T t) {
+  A* a = new A();
+  templated_delete_function<T>(t, a);
+  templated_access_function<T>(t, a);
+}
+
+template void templated_delete_function<int>(int, A*);
+template void templated_delete_function<bool>(bool, A*);
+template void templated_access_function<int>(int, A*);
+template void templated_access_function<bool>(bool, A*);
+template void templated_function_bad<int>(int);
+template void templated_function_bad<bool>(bool);
+
+void materialize_function_template_instances() {
+  templated_function_bad<int>(42);
+  templated_function_bad<bool>(true);
+}
+
 } // namespace deduplication

infer/tests/codetoanalyze/cpp/pulse/issues.exp

@@ -4,6 +4,8 @@ codetoanalyze/cpp/pulse/closures.cpp, implicit_ref_capture_destroy_invoke_bad, 6
 codetoanalyze/cpp/pulse/closures.cpp, ref_capture_destroy_invoke_bad, 6, USE_AFTER_LIFETIME, no_bucket, ERROR, [invalidation part of the trace starts here,memory is the address of a stack variable `s` whose lifetime has ended here,use-after-lifetime part of the trace starts here,`&s` captured as `s`,invalid access to `&f` here]
 codetoanalyze/cpp/pulse/deduplication.cpp, deduplication::SomeTemplatedClass<int*>::lifetime_error_bad, 2, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,when calling `templated_wrapper_delete_ok` here,memory was invalidated by `delete` on `a` here,use-after-lifetime part of the trace starts here,when calling `templated_wrapper_access_ok` here,invalid access to `a->f` here]
 codetoanalyze/cpp/pulse/deduplication.cpp, deduplication::SomeTemplatedClass<int>::lifetime_error_bad, 2, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,when calling `templated_wrapper_delete_ok` here,memory was invalidated by `delete` on `a` here,use-after-lifetime part of the trace starts here,when calling `templated_wrapper_access_ok` here,invalid access to `a->f` here]
+codetoanalyze/cpp/pulse/deduplication.cpp, deduplication::templated_function_bad<_Bool>, 3, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,when calling `deduplication::templated_delete_function` here,memory was invalidated by `delete` on `a` here,use-after-lifetime part of the trace starts here,assigned to `a`,when calling `deduplication::templated_access_function` here,invalid access to `a->f` here]
+codetoanalyze/cpp/pulse/deduplication.cpp, deduplication::templated_function_bad<int>, 3, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,when calling `deduplication::templated_delete_function` here,memory was invalidated by `delete` on `a` here,use-after-lifetime part of the trace starts here,assigned to `a`,when calling `deduplication::templated_access_function` here,invalid access to `a->f` here]
 codetoanalyze/cpp/pulse/interprocedural.cpp, delete_aliased_then_read_bad, 4, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,assigned to `y`,memory was invalidated by `delete` on `y` here,use-after-lifetime part of the trace starts here,assigned to `z`,when calling `wraps_read()` here,when calling `wraps_read_inner()` here,invalid access to `x->f` here]
 codetoanalyze/cpp/pulse/interprocedural.cpp, delete_inner_then_write_bad, 2, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,when calling `wraps_delete_inner()` here,memory was invalidated by `delete` on `x` here,use-after-lifetime part of the trace starts here,when calling `wraps_read()` here,when calling `wraps_read_inner()` here,invalid access to `x->f` here]
 codetoanalyze/cpp/pulse/interprocedural.cpp, delete_then_read_bad, 2, USE_AFTER_DELETE, no_bucket, ERROR, [invalidation part of the trace starts here,memory was invalidated by `delete` on `x` here,use-after-lifetime part of the trace starts here,when calling `wraps_read()` here,when calling `wraps_read_inner()` here,invalid access to `x->f` here]