[infer] implements call by procedure name

Summary:
Removes the need to have a procedure description when when executing a procedure call.

infer/src/backend/sil.ml

@@ -666,9 +666,9 @@ and attribute =
   | Auntaint
   | Adiv0 of path_pos (** value appeared in second argument of division in path position *)
   | Aobjc_null of exp (** the exp. is null because of a call to a method with exp as a null receiver *)
-  | Avariadic_function_argument of Procname.t * int * int (** (pn, n, i) the exp. is used as [i]th
-  argument of a call to the variadic
-  function [pn] that has [n] arguments *)
+  | Avariadic_function_argument of Procname.t * int * int
+  (** (pn, n, i) the exp. is used as [i]th argument of a call to the variadic function
+  [pn] that has [n] arguments *)
   | Aretval of Procname.t (** value was returned from a call to the given procedure *)
 
 (** Categories of attributes *)
@@ -3776,6 +3776,9 @@ let pp_tenv f (tenv : tenv) =
 let mk_pvar (name: Mangled.t) (proc_name: Procname.t) : pvar =
   { pv_name = name; pv_kind = Local_var proc_name }
 
+let mk_ret_var pname =
+  mk_pvar Ident.name_return pname
+
 (** [mk_pvar_callee name proc_name] creates a program var for a callee function with the given function name *)
 let mk_pvar_callee (name: Mangled.t) (proc_name: Procname.t) : pvar =
   { pv_name = name; pv_kind = Callee_var proc_name }

infer/src/backend/sil.mli

@@ -1318,6 +1318,9 @@ val loc_none : location
 (** [mk_pvar name proc_name suffix] creates a program var with the given function name and suffix *)
 val mk_pvar : Mangled.t -> Procname.t -> pvar
 
+(** [mk_ret_var proc_name] creates the retun pvar based on the procedure name *)
+val mk_ret_var : Procname.t -> pvar
+
 (** [mk_pvar_callee name proc_name] creates a program var for a callee function with the given function name *)
 val mk_pvar_callee : Mangled.t -> Procname.t -> pvar
 

infer/src/backend/specs.ml

@@ -663,6 +663,12 @@ let get_timestamp summary =
 let get_proc_name summary =
   summary.proc_name
 
+let get_ret_type summary =
+  summary.ret_type
+
+let get_formals summary =
+  summary.formals
+
 let get_attributes summary =
   summary.attributes
 

infer/src/backend/specs.mli

@@ -164,6 +164,12 @@ val get_proc_name : summary -> Procname.t
 (** Get the attributes of the procedure. *)
 val get_attributes : summary -> Sil.proc_attributes
 
+(** Get the return type of the procedure *)
+val get_ret_type : summary -> Sil.typ
+
+(** Get the formal paramters of the procedure *)
+val get_formals : summary -> (string * Sil.typ) list
+
 (** Get the flag with the given key for the procedure, if any *)
 val get_flag : Procname.t -> string -> string option
 

infer/src/backend/symExec.ml

@@ -514,17 +514,15 @@ let is_defined cfg pname =
   | Some pdesc -> Cfg.Procdesc.is_defined pdesc
 
 
-let call_should_be_skipped cfg caller_pname callee_pname =
-  let should_skip () =
-    match Specs.get_summary callee_pname with
-    | None -> true
-    | Some summary ->
-        Specs.get_flag callee_pname proc_flag_skip <> None (* check skip flag *)
-        || summary.Specs.attributes.Sil.is_abstract (* skip abstract methods *)
+let call_should_be_skipped callee_pname summary =
+  (* skip all procedures in intra-precedural mode *)
+  !Config.intraprocedural
+  (* check skip flag *)
+  || Specs.get_flag callee_pname proc_flag_skip <> None
+  (* skip abstract methods *)
+  || summary.Specs.attributes.Sil.is_abstract
   (* treat calls with no specs as skip functions in angelic mode *)
-        || (!Config.angelic_execution && Specs.get_specs_from_payload summary == []) in
-  if !Config.intraprocedural then true
-  else should_skip ()
+  || (!Config.angelic_execution && Specs.get_specs_from_payload summary == [])
 
 
 let report_raise_memory_leak tenv msg hpred prop =
@@ -950,14 +948,33 @@ let rec sym_exec cfg tenv pdesc _instr (_prop: Prop.normal Prop.t) path
         if call_flags.Sil.cf_virtual then
           resolve_virtual_pname cfg tenv prop_r n_actual_params fn
         else fn in
-      begin
-        match Cfg.Procdesc.find_from_name cfg fn with
-        | None ->
+      let ret_typ_opt =
+        match Cfg.Procdesc.find_from_name cfg resolved_pname with
+        | None -> None
+        | Some pd -> Some (Cfg.Procdesc.get_ret_type pd) in
+      let skip_call () =
+        let exn = Exceptions.Skip_function (Localise.desc_skip_function callee_pname) in
+        Reporting.log_info pname exn;
+        L.d_strln
+          ("Undefined function " ^ Procname.to_string callee_pname
+           ^ ", returning undefined value.");
+        (match Specs.get_summary pname with
+         | None -> ()
+         | Some summary ->
+            Specs.CallStats.trace
+              summary.Specs.stats.Specs.call_stats callee_pname loc
+              (Specs.CallStats.CR_skip) !Config.footprint);
         call_unknown_or_scan
-              false cfg pdesc tenv prop_r path ret_ids None n_actual_params fn loc
-        | Some callee_pdesc ->
-            let callee_pdesc' = proc_desc_copy cfg callee_pdesc fn resolved_pname in
-            sym_exec_call cfg pdesc tenv prop_r path ret_ids n_actual_params callee_pdesc' loc
+          false cfg pdesc tenv prop_r path
+          ret_ids ret_typ_opt n_actual_params resolved_pname loc in
+      begin
+        match Specs.get_summary resolved_pname with
+        | None -> skip_call ()
+        | Some summary when call_should_be_skipped resolved_pname summary ->
+           skip_call ()
+        | Some summary ->
+           sym_exec_call
+             cfg pdesc tenv prop_r path ret_ids n_actual_params summary loc
       end
   | Sil.Call (ret_ids, fun_exp, actual_params, loc, call_flags) -> (** Call via function pointer *)
       let (prop_r, n_actual_params) = normalize_params pdesc _prop actual_params in
@@ -1205,10 +1222,10 @@ and call_unknown_or_scan is_scan cfg pdesc tenv pre path
 
 
 (** Perform symbolic execution for a function call *)
-and sym_exec_call cfg pdesc tenv pre path ret_ids actual_pars callee_pdesc loc =
+and sym_exec_call cfg pdesc tenv pre path ret_ids actual_pars summary loc =
   let caller_pname = Cfg.Procdesc.get_proc_name pdesc in
-  let callee_pname = Cfg.Procdesc.get_proc_name callee_pdesc in
-  let ret_typ = Cfg.Procdesc.get_ret_type callee_pdesc in
+  let callee_pname = Specs.get_proc_name summary in
+  let ret_typ = Specs.get_ret_type summary in
   let check_return_value_ignored () = (* check if the return value of the call is ignored, and issue a warning *)
     let is_ignored = match ret_typ, ret_ids with
       | Sil.Tvoid, _ -> false
@@ -1226,22 +1243,8 @@ and sym_exec_call cfg pdesc tenv pre path ret_ids actual_pars callee_pdesc loc =
       let pre_opt = State.get_normalized_pre (Abs.abstract_no_symop caller_pname) in
       Reporting.log_warning caller_pname ~pre: pre_opt exn in
   check_inherently_dangerous_function caller_pname callee_pname;
-  if call_should_be_skipped cfg caller_pname callee_pname then
   begin
-      let exn = Exceptions.Skip_function (Localise.desc_skip_function callee_pname) in
-      Reporting.log_info caller_pname exn;
-      L.d_strln ("Undefined function " ^ Procname.to_string callee_pname ^ ", returning undefined value.");
-      (match Specs.get_summary caller_pname with
-       | None -> ()
-       | Some summary ->
-          Specs.CallStats.trace
-            summary.Specs.stats.Specs.call_stats callee_pname loc
-            (Specs.CallStats.CR_skip) !Config.footprint);
-      call_unknown_or_scan
-        false cfg pdesc tenv pre path ret_ids (Some ret_typ) actual_pars callee_pname loc
-    end
-  else begin
-    let formal_types = list_map (fun (_, typ) -> typ) (Cfg.Procdesc.get_formals callee_pdesc) in
+    let formal_types = list_map (fun (_, typ) -> typ) (Specs.get_formals summary) in
     let rec comb actual_pars formal_types =
       match actual_pars, formal_types with
       | [], [] -> actual_pars
@@ -1268,7 +1271,7 @@ and sym_exec_call cfg pdesc tenv pre path ret_ids actual_pars callee_pdesc loc =
     (* In case we call an objc instance method we add and extra spec *)
     (* were the receiver is null and the semantics of the call is nop*)
     if (!Sil.curr_language <> Sil.Java) && !Config.objc_method_call_semantics &&
-    (Cfg.Procdesc.get_attributes callee_pdesc).Sil.is_objc_instance_method then
+    (Specs.get_attributes summary).Sil.is_objc_instance_method then
       handle_objc_method_call actual_pars actual_params pre tenv cfg ret_ids pdesc callee_pname loc path
     else  (* non-objective-c method call. Standard tabulation *)
     Tabulation.exe_function_call tenv cfg ret_ids pdesc callee_pname loc actual_params pre path
@@ -2047,13 +2050,14 @@ module ModelBuiltins = struct
           | Sil.Lvar pvar, _ ->
               let fun_name = Sil.pvar_get_name pvar in
               let fun_string = Mangled.to_string fun_name in
-              let callee_pdesc =
-                match Cfg.Procdesc.find_from_name cfg (Procname.from_string fun_string) with
-                | Some callee_pdesc -> callee_pdesc
-                | None -> assert false in
               L.d_strln ("pthread_create: calling function " ^ fun_string);
+              begin
+                match Specs.get_summary (Procname.from_string fun_string) with
+                | None -> assert false
+                | Some callee_summary ->
                    sym_exec_call
-                cfg pdesc tenv prop path ret_ids [(routine_arg, snd arg)] callee_pdesc loc
+                     cfg pdesc tenv prop path ret_ids [(routine_arg, snd arg)] callee_summary loc
+              end
           | _ ->
               L.d_str "pthread_create: unknown function "; Sil.d_exp routine_name; L.d_strln ", skipping call.";
               [(prop, path)])

infer/src/backend/tabulation.ml

@@ -672,13 +672,8 @@ let combine
       Prop.normalize (Prop.replace_pi (Prop.get_pi post_p1 @ new_footprint_pi) post_p1') in
 
     let post_p3 = (** replace [result|callee] with an aux variable dedicated to this proc *)
-      let callee_pdesc =
-        match Cfg.Procdesc.find_from_name cfg callee_pname with
-        | Some pd -> pd
-        | None ->
-            L.d_strln ("proc_desc not_found for " ^ Procname.to_string callee_pname);
-            assert false in
-      let callee_ret_pvar = Sil.Lvar (Sil.pvar_to_callee callee_pname (Cfg.Procdesc.get_ret_var callee_pdesc)) in
+      let callee_ret_pvar =
+        Sil.Lvar (Sil.pvar_to_callee callee_pname (Sil.mk_ret_var callee_pname)) in
       match Prop.prop_iter_create post_p2 with
       | None -> post_p2
       | Some iter ->