[racerd] simplify reconciliation of caller/callee thread context

Reviewed By: ngorogiannis

Differential Revision: D7163334

fbshipit-source-id: cf10e1b

infer/src/concurrency/RacerD.ml

@@ -501,13 +501,13 @@ module TransferFunctions (CFG : ProcCfg.S) = struct
                         ~callee_astate:locks
                     in
                     let threads =
-                      match (astate.threads, threads) with
+                      (* if we know the callee runs on the main thread, assume the caller does too.
-                      | _, ThreadsDomain.AnyThreadButSelf | AnyThreadButSelf, _ ->
+                         otherwise, keep the caller's thread context *)
-                          ThreadsDomain.AnyThreadButSelf
+                      match threads with
-                      | _, ThreadsDomain.AnyThread ->
+                      | ThreadsDomain.AnyThreadButSelf ->
-                          astate.threads
+                          threads
                       | _ ->
-                          ThreadsDomain.join threads astate.threads
+                          astate.threads
                     in
                     let accesses =
                       add_callee_accesses astate accesses locks threads actuals callee_pname pdesc