[cost] Remove unused IO Cost kind

Summary: We don't report and IO Cost and are not planning to do so in the near future. Let's remove it from cost kinds.

Reviewed By: ngorogiannis

Differential Revision: D23499160

fbshipit-source-id: 7281da3af
master
Ezgi Çiçek 5 years ago committed by Facebook GitHub Bot
parent c3909c0434
commit dab523f7eb

@ -7,35 +7,20 @@
open! IStd open! IStd
module F = Format module F = Format
type t = OperationCost | AllocationCost | IOCost [@@deriving compare] type t = OperationCost | AllocationCost [@@deriving compare]
let to_issue_string = function
| OperationCost ->
"EXECUTION_TIME"
| AllocationCost ->
"ALLOCATION"
| IOCost ->
"IO"
let to_issue_string = function OperationCost -> "EXECUTION_TIME" | AllocationCost -> "ALLOCATION"
let to_complexity_string = function let to_complexity_string = function
| AllocationCost -> | AllocationCost ->
"Allocation complexity" "Allocation complexity"
| OperationCost -> | OperationCost ->
"Time complexity" "Time complexity"
| IOCost ->
"IO complexity"
let pp f k = let pp f k =
let k_str = let k_str =
match k with match k with OperationCost -> "Execution Cost" | AllocationCost -> "Allocation Cost"
| OperationCost ->
"Execution Cost"
| AllocationCost ->
"Allocation Cost"
| IOCost ->
"IO Cost"
in in
F.pp_print_string f k_str F.pp_print_string f k_str
@ -45,8 +30,6 @@ let to_json_cost_info c = function
c.Jsonbug_t.exec_cost c.Jsonbug_t.exec_cost
| AllocationCost -> | AllocationCost ->
assert false assert false
| IOCost ->
assert false
type kind_spec = {kind: t; (* for non-diff analysis *) top_and_unreachable: bool} type kind_spec = {kind: t; (* for non-diff analysis *) top_and_unreachable: bool}

@ -7,7 +7,7 @@
open! IStd open! IStd
type t = OperationCost | AllocationCost | IOCost [@@deriving compare] type t = OperationCost | AllocationCost [@@deriving compare]
type kind_spec = {kind: t; (* for non-diff analysis *) top_and_unreachable: bool} type kind_spec = {kind: t; (* for non-diff analysis *) top_and_unreachable: bool}

@ -49,9 +49,8 @@ module BasicCostWithReason = struct
let pp_hum = pp let pp_hum = pp
end end
(** Module to simulate a record (** Module to simulate a record [{OperationCost:BasicCost.t; AllocationCost: BasicCost.t}] with a
[{OperationCost:BasicCost.t; AllocationCost: BasicCost.t; IOCost:BasicCost.t}] with a map map [{OperationCost, AllocationCost} -> BasicCost.t] *)
[{OperationCost, AllocationCost, IOCost} -> BasicCost.t] *)
module VariantCostMap = struct module VariantCostMap = struct
include PrettyPrintable.PPMonoMapOfPPMap (CostIssues.CostKindMap) (BasicCostWithReason) include PrettyPrintable.PPMonoMapOfPPMap (CostIssues.CostKindMap) (BasicCostWithReason)

@ -65,7 +65,7 @@ val get_operation_cost : t -> BasicCostWithReason.t
val map : f:(BasicCostWithReason.t -> BasicCostWithReason.t) -> t -> t val map : f:(BasicCostWithReason.t -> BasicCostWithReason.t) -> t -> t
val zero_record : t val zero_record : t
(** Map representing cost record \{OperationCost:0; AllocationCost:0; IOCost:0\} *) (** Map representing cost record \{OperationCost:0; AllocationCost:0\} *)
val mult_by : t -> nb_exec:BasicCost.t -> t val mult_by : t -> nb_exec:BasicCost.t -> t
(** Special map where each element is multiplied by the number of executions *) (** Special map where each element is multiplied by the number of executions *)
@ -74,10 +74,10 @@ val plus : t -> t -> t
(** Union of two maps where common costs are added together *) (** Union of two maps where common costs are added together *)
val unit_cost_atomic_operation : t val unit_cost_atomic_operation : t
(** Map representing cost record \{OperationCost:1; AllocationCost:0; IOCost:0\} *) (** Map representing cost record \{OperationCost:1; AllocationCost:0\} *)
val unit_cost_allocation : t val unit_cost_allocation : t
(** Map representing cost record \{OperationCost:0; AllocationCost:1; IOCost:0\} *) (** Map representing cost record \{OperationCost:0; AllocationCost:1\} *)
val of_operation_cost : BasicCost.t -> t val of_operation_cost : BasicCost.t -> t
(** Map representing cost record \{OperationCost:operation_cost; AllocationCost:0; IOCost:0\} *) (** Map representing cost record \{OperationCost:operation_cost; AllocationCost:0\} *)

Loading…
Cancel
Save